Skip to content

Commit 832c7d6

Browse files
authored
MINOR: ignore result of "missing build scan" (#20659)
Always mark the result of "missing build scan" as successful, not as failing, for 4.0 and 4.1. Two reasons causing missing build scan: - 4.0 does not have the KAFKA-18748 patches. - The JDK version used by `ci-complete` is inconsistent with other active branches, causing the build report task to fail. The real solution will be in [KAFKA-19768](https://issues.apache.org/jira/browse/KAFKA-19768). Reviewers: David Arthur <[email protected]>, Chia-Ping Tsai <[email protected]>
1 parent 727aae9 commit 832c7d6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci-complete.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ run-name: Build Scans for ${{ github.event.workflow_run.display_title}}
3838
jobs:
3939
upload-build-scan:
4040
# Skip this workflow if the CI run was skipped or cancelled
41-
if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure') && github.event.workflow_run.head_branch != '4.0'
41+
if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure')
4242
runs-on: ubuntu-latest
4343
strategy:
4444
fail-fast: false
@@ -89,7 +89,7 @@ jobs:
8989
url: '${{ github.event.workflow_run.html_url }}'
9090
description: 'Could not find build scan'
9191
context: Gradle Build Scan / ${{ env.status-context }}
92-
state: 'error'
92+
state: 'success' # Always mark as successful as a temporary fix; non-trunk branches will miss build scan. Real fix in KAFKA-19768
9393
- name: Publish Scan
9494
id: publish-build-scan
9595
if: ${{ steps.download-build-scan.outcome == 'success' }}

0 commit comments

Comments
 (0)