Transaction::commit succeeds on a read-only table #3462

use std::collections::HashMap;

use iceberg::memory::{MEMORY_CATALOG_WAREHOUSE, MemoryCatalogBuilder};
use iceberg::spec::Schema;
use iceberg::table::StaticTable;
use iceberg::transaction::{ApplyTransactionAction, Transaction};
use iceberg::{Catalog, CatalogBuilder, NamespaceIdent, Result, TableCreation};

#[tokio::main]
async fn main() -> Result<()> {
    let catalog = MemoryCatalogBuilder::default()
        .load(
            "memory",
            HashMap::from([(
                MEMORY_CATALOG_WAREHOUSE.to_string(),
                "memory:///warehouse".to_string(),
            )]),
        )
        .await?;

    let ns = NamespaceIdent::new("ns".to_string());
    catalog.create_namespace(&ns, HashMap::new()).await?;
    let table = catalog
        .create_table(
            &ns,
            TableCreation::builder()
                .name("t".to_string())
                .schema(Schema::builder().build()?)
                .build(),
        )
        .await?;

    let readonly = StaticTable::from_metadata_file(
        table.metadata_location_result()?,
        table.identifier().clone(),
        table.file_io().clone(),
    )
    .await?
    .into_table();

    let tx = Transaction::new(&readonly);
    let tx = tx
        .update_table_properties()
        .set("written".to_string(), "yes".to_string())
        .apply(tx)?;

    tx.commit(&catalog).await?;
    println!("success writing to a read-only table");

    Ok(())
}