Skip to content

Commit dc7a2b4

Browse files
committed
feat: add test for Or serialization alone
1 parent 4197536 commit dc7a2b4

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

tests/expressions/test_expressions.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -705,10 +705,6 @@ def test_or() -> None:
705705
# Some syntactic sugar
706706
assert or_ == null | nan
707707

708-
assert (
709-
or_.model_dump_json()
710-
== '{"type":"or","left":"IsNull(term=Reference(name=\'a\'))","right":"IsNaN(term=Reference(name=\'b\'))"}'
711-
)
712708
assert str(or_) == f"Or(left={str(null)}, right={str(nan)})"
713709
assert repr(or_) == f"Or(left={repr(null)}, right={repr(nan)})"
714710
assert or_ == eval(repr(or_))
@@ -718,6 +714,17 @@ def test_or() -> None:
718714
null | "abc" # type: ignore
719715

720716

717+
def test_or_serialization() -> None:
718+
left = EqualTo("a", 10)
719+
right = EqualTo("b", 20)
720+
or_ = Or(left, right)
721+
722+
assert (
723+
or_.model_dump_json()
724+
== '{"type":"or","left":{"term":"a","type":"eq","value":10},"right":{"term":"b","type":"eq","value":20}}'
725+
)
726+
727+
721728
def test_not() -> None:
722729
null = IsNull(Reference("a"))
723730
not_ = Not(null)

0 commit comments

Comments
 (0)