Skip to content

Commit c895a16

Browse files
committed
property fields
1 parent 4dc01aa commit c895a16

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

pyiceberg/view/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ def current_version(self) -> ViewVersion:
5454
"""Get the version of this view."""
5555
return next(version for version in self.metadata.versions if version.version_id == self.metadata.current_version_id)
5656

57+
@property
5758
def versions(self) -> list[ViewVersion]:
5859
"""Get the versions of this view."""
5960
return self.metadata.versions
@@ -66,6 +67,7 @@ def history(self) -> list[ViewHistoryEntry]:
6667
"""Get the version of this history view."""
6768
return self.metadata.version_log
6869

70+
@property
6971
def properties(self) -> dict[str, str]:
7072
"""Return a map of string properties for this view."""
7173
return self.metadata.properties

tests/test_view.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def test_view_current_version(view: View) -> None:
5656

5757

5858
def test_view_versions(view: View) -> None:
59-
versions = view.versions()
59+
versions = view.versions
6060
assert len(versions) == 1
6161
assert isinstance(versions[0], ViewVersion)
6262
assert versions[0].version_id == 1
@@ -78,7 +78,7 @@ def test_view_history(view: View) -> None:
7878

7979

8080
def test_view_properties(view: View) -> None:
81-
assert view.properties() == {"comment": "this is a test view"}
81+
assert view.properties == {"comment": "this is a test view"}
8282

8383

8484
def test_view_location(view: View) -> None:
@@ -107,7 +107,7 @@ def test_view_schemas_multiple(example_view_metadata_v1_multiple_versions: dict[
107107

108108
def test_view_versions_multiple(example_view_metadata_v1_multiple_versions: dict[str, Any]) -> None:
109109
view = View(("default", "test_view"), ViewMetadata.model_validate(example_view_metadata_v1_multiple_versions))
110-
assert len(view.versions()) == 2
110+
assert len(view.versions) == 2
111111
assert view.current_version().version_id == 2
112112

113113

0 commit comments

Comments
 (0)