Skip to content

Commit 756ee0b

Browse files
committed
add abstract methods to additional classes
1 parent ef6be83 commit 756ee0b

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

pyiceberg/catalog/dynamodb.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None:
550550
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
551551
raise NotImplementedError
552552

553+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
554+
raise NotImplementedError
555+
553556
def _get_iceberg_table_item(self, database_name: str, table_name: str) -> Dict[str, Any]:
554557
try:
555558
return self._get_dynamo_item(identifier=f"{database_name}.{table_name}", namespace=database_name)

pyiceberg/catalog/glue.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -826,6 +826,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None:
826826
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
827827
raise NotImplementedError
828828

829+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
830+
raise NotImplementedError
831+
829832
@staticmethod
830833
def __is_iceberg_table(table: "TableTypeDef") -> bool:
831834
return table.get("Parameters", {}).get(TABLE_TYPE, "").lower() == ICEBERG

pyiceberg/catalog/hive.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,9 @@ def list_views(self, namespace: Union[str, Identifier]) -> List[Identifier]:
475475
def view_exists(self, identifier: Union[str, Identifier]) -> bool:
476476
raise NotImplementedError
477477

478+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
479+
raise NotImplementedError
480+
478481
def _create_lock_request(self, database_name: str, table_name: str) -> LockRequest:
479482
lock_component: LockComponent = LockComponent(
480483
level=LockLevel.TABLE, type=LockType.EXCLUSIVE, dbname=database_name, tablename=table_name, isTransactional=True

pyiceberg/catalog/noop.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,3 +128,6 @@ def view_exists(self, identifier: Union[str, Identifier]) -> bool:
128128

129129
def drop_view(self, identifier: Union[str, Identifier]) -> None:
130130
raise NotImplementedError
131+
132+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
133+
raise NotImplementedError

pyiceberg/catalog/sql.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -744,3 +744,6 @@ def close(self) -> None:
744744
"""
745745
if hasattr(self, "engine"):
746746
self.engine.dispose()
747+
748+
def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
749+
raise NotImplementedError

0 commit comments

Comments
 (0)