Skip to content

Commit 230d088

Browse files
committed
fix: separate the test_hive_properties test
1 parent ff149e8 commit 230d088

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

tests/integration/test_reads.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -112,22 +112,26 @@ def test_table_properties(catalog: Catalog) -> None:
112112
table.transaction().set_properties(property_name=None).commit_transaction()
113113
assert "None type is not a supported value in properties: property_name" in str(exc_info.value)
114114

115-
if isinstance(catalog, HiveCatalog):
116-
table.transaction().set_properties({"abc": "def", "p1": "123"}).commit_transaction()
117115

118-
hive_client: _HiveClient = _HiveClient(catalog.properties["uri"])
116+
@pytest.mark.integration
117+
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive")])
118+
def test_hive_properties(catalog: Catalog) -> None:
119+
table = create_table(catalog)
120+
table.transaction().set_properties({"abc": "def", "p1": "123"}).commit_transaction()
119121

120-
with hive_client as open_client:
121-
hive_table = open_client.get_table(*TABLE_NAME)
122-
assert hive_table.parameters.get("abc") == "def"
123-
assert hive_table.parameters.get("p1") == "123"
124-
assert hive_table.parameters.get("not_exist_parameter") is None
122+
hive_client: _HiveClient = _HiveClient(catalog.properties["uri"])
125123

126-
table.transaction().remove_properties("abc").commit_transaction()
124+
with hive_client as open_client:
125+
hive_table = open_client.get_table(*TABLE_NAME)
126+
assert hive_table.parameters.get("abc") == "def"
127+
assert hive_table.parameters.get("p1") == "123"
128+
assert hive_table.parameters.get("not_exist_parameter") is None
127129

128-
with hive_client as open_client:
129-
hive_table = open_client.get_table(*TABLE_NAME)
130-
assert hive_table.parameters.get("abc") is None
130+
table.transaction().remove_properties("abc").commit_transaction()
131+
132+
with hive_client as open_client:
133+
hive_table = open_client.get_table(*TABLE_NAME)
134+
assert hive_table.parameters.get("abc") is None
131135

132136

133137
@pytest.mark.integration

0 commit comments

Comments
 (0)