Skip to content

Commit e8cb1b3

Browse files
committed
feat: add DataFile aggregate evaluation
1 parent b37a0aa commit e8cb1b3

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

src/iceberg/expression/expression.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class ICEBERG_EXPORT Expression : public util::Formattable {
7777
/// \brief Returns whether this expression will accept the same values as another.
7878
/// \param other another expression
7979
/// \return true if the expressions are equivalent
80-
virtual bool Equals([[maybe_unused]] const Expression& other) const {
80+
virtual bool Equals(const Expression& other) const {
8181
// only bound predicates can be equivalent
8282
return false;
8383
}

src/iceberg/expression/expression_visitor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@ class ICEBERG_EXPORT BoundVisitor : public ExpressionVisitor<R> {
117117

118118
/// \brief Visit an IS_NAN bound expression.
119119
/// \param expr The bound expression being tested
120-
virtual Result<R> IsNaN([[maybe_unused]] const std::shared_ptr<Bound>& expr) {
120+
virtual Result<R> IsNaN(const std::shared_ptr<Bound>& expr) {
121121
return NotSupported("IsNaN operation is not supported by this visitor");
122122
}
123123

124124
/// \brief Visit a NOT_NAN bound expression.
125125
/// \param expr The bound expression being tested
126-
virtual Result<R> NotNaN([[maybe_unused]] const std::shared_ptr<Bound>& expr) {
126+
virtual Result<R> NotNaN(const std::shared_ptr<Bound>& expr) {
127127
return NotSupported("NotNaN operation is not supported by this visitor");
128128
}
129129

src/iceberg/schema.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ class ICEBERG_EXPORT Schema : public StructType {
5151
explicit Schema(std::vector<SchemaField> fields,
5252
std::optional<int32_t> schema_id = std::nullopt);
5353

54-
using StructType::Equals;
55-
5654
/// \brief Get the schema ID.
5755
///
5856
/// A schema is identified by a unique ID for the purposes of schema

src/iceberg/test/aggregate_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
#include "iceberg/expression/binder.h"
2525
#include "iceberg/expression/expressions.h"
26-
#include "iceberg/manifest_entry.h"
26+
#include "iceberg/manifest/manifest_entry.h"
2727
#include "iceberg/row/struct_like.h"
2828
#include "iceberg/schema.h"
2929
#include "iceberg/test/matchers.h"

0 commit comments

Comments
 (0)