feat: transactional UpdateProperties method support

Author: shuxu.li

src/iceberg/meson.build

@@ -41,6 +41,7 @@ configure_file(
 iceberg_include_dir = include_directories('..')
 iceberg_sources = files(
     'arrow_c_data_guard_internal.cc',
+    'base_transaction.cc',
     'catalog/memory/in_memory_catalog.cc',
     'expression/binder.cc',
     'expression/evaluator.cc',
@@ -65,6 +66,7 @@ iceberg_sources = files(
     'partition_field.cc',
     'partition_spec.cc',
     'partition_summary.cc',
+    'pending_update.cc',
     'row/arrow_array_wrapper.cc',
     'row/manifest_wrapper.cc',
     'row/struct_like.cc',

src/iceberg/pending_update.cc

@@ -39,7 +39,10 @@ PropertiesUpdate& PropertiesUpdate::Remove(std::string const& key) {
 }
 
 Result<PropertiesUpdateChanges> PropertiesUpdate::Apply() {
-  return PropertiesUpdateChanges{updates_, removals_};
+  return PropertiesUpdateChanges{
+      .updates = updates_,
+      .removals = removals_,
+  };
 }
 
 Status PropertiesUpdate::ApplyResult(TableMetadataBuilder& builder,

src/iceberg/test/CMakeLists.txt

@@ -80,14 +80,14 @@ add_iceberg_test(schema_test
 add_iceberg_test(table_test
                  SOURCES
                  json_internal_test.cc
+                 base_transaction_test.cc
                  pending_update_test.cc
                  schema_json_test.cc
                  table_test.cc
                  table_metadata_builder_test.cc
                  table_requirement_test.cc
                  table_update_test.cc
-                 test_common.cc
-                 transaction_pending_update_test.cc)
+                 test_common.cc)
 
 add_iceberg_test(expression_test
                  SOURCES

…/test/transaction_pending_update_test.cc src/iceberg/test/base_transaction_test.ccsrc/iceberg/test/transaction_pending_update_test.cc renamed to src/iceberg/test/base_transaction_test.cc src/iceberg/test/transaction_pending_update_test.cc renamed to src/iceberg/test/base_transaction_test.cc

@@ -17,9 +17,10 @@
  * under the License.
  */
 
+#include "iceberg/base_transaction.h"
+
 #include <gtest/gtest.h>
 
-#include "iceberg/base_transaction.h"
 #include "iceberg/partition_spec.h"
 #include "iceberg/pending_update.h"
 #include "iceberg/sort_order.h"
@@ -68,7 +69,7 @@ std::shared_ptr<Table> CreateTestTable(const TableIdentifier& identifier,
 }
 }  // namespace
 
-TEST(TransactionPendingUpdateTest, CommitSetPropertiesUsesCatalog) {
+TEST(BaseTransactionTest, CommitSetPropertiesUsesCatalog) {
   auto metadata = CreateBaseMetadata();
   const auto identifier = MakeIdentifier();
   auto catalog = std::make_shared<NiceMock<MockCatalog>>();
@@ -93,13 +94,13 @@ TEST(TransactionPendingUpdateTest, CommitSetPropertiesUsesCatalog) {
         auto it = updated.find("new-key");
         EXPECT_NE(it, updated.end());
         EXPECT_EQ("new-value", it->second);
-        return Result<std::unique_ptr<Table>>(std::unique_ptr<Table>());
+        return {std::unique_ptr<Table>()};
       });
 
   EXPECT_THAT(transaction->CommitTransaction(), IsOk());
 }
 
-TEST(TransactionPendingUpdateTest, RemovePropertiesSkipsMissingKeys) {
+TEST(BaseTransactionTest, RemovePropertiesSkipsMissingKeys) {
   auto metadata = CreateBaseMetadata();
   const auto identifier = MakeIdentifier();
   auto catalog = std::make_shared<NiceMock<MockCatalog>>();
@@ -121,13 +122,13 @@ TEST(TransactionPendingUpdateTest, RemovePropertiesSkipsMissingKeys) {
             dynamic_cast<const table::RemoveProperties*>(updates.front().get());
         EXPECT_NE(remove_update, nullptr);
         EXPECT_THAT(remove_update->removed(), ElementsAre("existing"));
-        return Result<std::unique_ptr<Table>>(std::unique_ptr<Table>());
+        return {std::unique_ptr<Table>()};
       });
 
   EXPECT_THAT(transaction->CommitTransaction(), IsOk());
 }
 
-TEST(TransactionPendingUpdateTest, AggregatesMultiplePendingUpdates) {
+TEST(BaseTransactionTest, AggregatesMultiplePendingUpdates) {
   auto metadata = CreateBaseMetadata();
   const auto identifier = MakeIdentifier();
   auto catalog = std::make_shared<NiceMock<MockCatalog>>();
@@ -159,7 +160,7 @@ TEST(TransactionPendingUpdateTest, AggregatesMultiplePendingUpdates) {
         EXPECT_NE(remove_update, nullptr);
         EXPECT_THAT(remove_update->removed(), ElementsAre("existing"));
 
-        return Result<std::unique_ptr<Table>>(std::unique_ptr<Table>());
+        return {std::unique_ptr<Table>()};
       });
 
   EXPECT_THAT(transaction->CommitTransaction(), IsOk());