From fd6c1aeed1b2ef50fc1a80a2ca59d9b3d4ecd086 Mon Sep 17 00:00:00 2001 From: Marta Kuczora Date: Thu, 16 Oct 2025 11:00:54 +0200 Subject: [PATCH] HIVE-29272: Query-based MINOR compaction should not consider minOpenWriteId This is not the final fix, this is just a quick commit to see if removing the check from the MINOR compacion causes any test failures. --- .../hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java index 98196d20bc38..44c5c0d4ec3e 100644 --- a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java +++ b/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java @@ -320,10 +320,9 @@ private void buildAddClauseForAlter(StringBuilder query) { query.setLength(0); return; // avoid NPEs, don't throw an exception but return an empty query } - long minWriteID = validWriteIdList.getMinOpenWriteId() == null ? 1 : validWriteIdList.getMinOpenWriteId(); long highWatermark = validWriteIdList.getHighWatermark(); List deltas = dir.getCurrentDirectories().stream().filter( - delta -> delta.isDeleteDelta() == isDeleteDelta && delta.getMaxWriteId() <= highWatermark && delta.getMinWriteId() >= minWriteID) + delta -> delta.isDeleteDelta() == isDeleteDelta && delta.getMaxWriteId() <= highWatermark) .collect(Collectors.toList()); if (deltas.isEmpty()) { query.setLength(0); // no alter query needed; clear StringBuilder