correction for rebased iceberg view commit recently merged to master

Change-Id: Ie3440239248870fb44c6e956d5be10271b28a1a0

Author: ramitg254

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

@@ -2148,8 +2148,7 @@ public List<Partition> getPartitions(org.apache.hadoop.hive.ql.metadata.Table hm
 
   public boolean isPartitioned(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
     if (BaseHiveIcebergMetaHook.isIcebergView(hmsTable.getTTable())) {
-      List<FieldSchema> partCols = hmsTable.getPartCols();
-      return partCols != null && !partCols.isEmpty();
+      return !hmsTable.getPartitionKeys().isEmpty();
     }
     if (hmsTable.getMetaTable() != null || !hmsTable.getTTable().isSetId()) {
       return false;
@@ -2297,8 +2296,7 @@ public boolean canPerformMetadataDelete(org.apache.hadoop.hive.ql.metadata.Table
   @Override
   public List<FieldSchema> getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
     if (BaseHiveIcebergMetaHook.isIcebergView(hmsTable.getTTable())) {
-      List<FieldSchema> partCols = hmsTable.getPartCols();
-      return partCols != null ? partCols : Collections.emptyList();
+      return hmsTable.getPartitionKeys();
     }
     if (hmsTable.getMetaTable() != null || !hmsTable.getTTable().isSetId()) {
       return Collections.emptyList();

ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java

@@ -766,7 +766,7 @@ private void  ensureColumnsIndexed() {
     }
     Map<String, TableColumn> indexedColumns = new HashMap<>();
     List<FieldSchema> fsList = new ArrayList<>(getColsInternal(false));
-    if (!hasNonNativePartitionSupport()) {
+    if (!hasNonNativePartitionSupport() || isView()) {
       fsList.addAll(getPartitionKeys());
     }
     for (int i = 0; i < fsList.size(); i++) {
@@ -837,7 +837,7 @@ private List<FieldSchema> getColsInternal(boolean forMs) {
    */
   public List<FieldSchema> getAllCols() {
     List<FieldSchema> fsList = new ArrayList<>(getColsInternal(false));
-    if (!hasNonNativePartitionSupport()) {
+    if (!hasNonNativePartitionSupport() || isView()) {
       fsList.addAll(getPartitionKeys());
     }
     return fsList;