From e70c3bfbe48b43127acefb25b7e03440256c2e08 Mon Sep 17 00:00:00 2001 From: Anton Borisov Date: Tue, 3 Mar 2026 12:43:46 +0000 Subject: [PATCH 1/2] chore: fix mut schema builder public api --- crates/fluss/src/metadata/table.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/fluss/src/metadata/table.rs b/crates/fluss/src/metadata/table.rs index 7f0d2e2a..dba9a523 100644 --- a/crates/fluss/src/metadata/table.rs +++ b/crates/fluss/src/metadata/table.rs @@ -234,8 +234,8 @@ impl SchemaBuilder { Ok(self) } - pub fn build(&mut self) -> Result { - let columns = Self::normalize_columns(&mut self.columns, self.primary_key.as_ref())?; + pub fn build(&self) -> Result { + let columns = Self::normalize_columns(&self.columns, self.primary_key.as_ref())?; let column_names: HashSet<_> = columns.iter().map(|c| &c.name).collect(); for auto_inc_col in &self.auto_increment_col_names { @@ -266,7 +266,7 @@ impl SchemaBuilder { } fn normalize_columns( - columns: &mut [Column], + columns: &[Column], primary_key: Option<&PrimaryKey>, ) -> Result> { let names: Vec<_> = columns.iter().map(|c| &c.name).collect(); From 349875cdefd5c05288f1b69eb656406687671a7b Mon Sep 17 00:00:00 2001 From: Anton Borisov Date: Tue, 3 Mar 2026 12:55:11 +0000 Subject: [PATCH 2/2] fix clippy warning --- crates/examples/Cargo.toml | 2 +- crates/fluss/src/test_utils.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/examples/Cargo.toml b/crates/examples/Cargo.toml index cce6faf2..26251cc7 100644 --- a/crates/examples/Cargo.toml +++ b/crates/examples/Cargo.toml @@ -37,4 +37,4 @@ path = "src/example_kv_table.rs" [[example]] name = "example-partitioned-upsert-lookup" -path = "src/example_partitioned_kv_table.rs" \ No newline at end of file +path = "src/example_partitioned_kv_table.rs" diff --git a/crates/fluss/src/test_utils.rs b/crates/fluss/src/test_utils.rs index 752d4224..47bb2ea8 100644 --- a/crates/fluss/src/test_utils.rs +++ b/crates/fluss/src/test_utils.rs @@ -25,7 +25,7 @@ use std::sync::Arc; pub(crate) fn build_table_info(table_path: TablePath, table_id: i64, buckets: i32) -> TableInfo { let row_type = DataTypes::row(vec![DataField::new("id", DataTypes::int(), None)]); - let mut schema_builder = Schema::builder().with_row_type(&row_type); + let schema_builder = Schema::builder().with_row_type(&row_type); let schema = schema_builder.build().expect("schema build"); let table_descriptor = TableDescriptor::builder() .schema(schema)