adressed review

Author: Prajwal-banakar

bindings/cpp/src/ffi_converter.hpp

@@ -61,7 +61,6 @@ inline ffi::FfiConfig to_ffi_config(const Configuration& config) {
     ffi_config.scanner_log_fetch_wait_max_time_ms = config.scanner_log_fetch_wait_max_time_ms;
     ffi_config.scanner_log_fetch_max_bytes_for_bucket = config.scanner_log_fetch_max_bytes_for_bucket;
     ffi_config.writer_batch_timeout_ms = config.writer_batch_timeout_ms;
-    ffi_config.writer_batch_timeout_ms = config.writer_batch_timeout_ms;
     ffi_config.connect_timeout_ms = config.connect_timeout_ms;
     ffi_config.security_protocol = rust::String(config.security_protocol);
     ffi_config.security_sasl_mechanism = rust::String(config.security_sasl_mechanism);

bindings/python/src/config.rs

@@ -97,25 +97,25 @@ impl Config {
                                 ))
                             })?;
                     }
-                    "scanner.log.fetch-max-bytes" => {
+                    "scanner.log.fetch.max-bytes" => {
                         config.scanner_log_fetch_max_bytes = value.parse::<i32>().map_err(|e| {
                             FlussError::new_err(format!("Invalid value '{value}' for '{key}': {e}"))
                         })?;
                     }
-                    "scanner.log.fetch-min-bytes" => {
+                    "scanner.log.fetch.min-bytes" => {
                         config.scanner_log_fetch_min_bytes = value.parse::<i32>().map_err(|e| {
                             FlussError::new_err(format!("Invalid value '{value}' for '{key}': {e}"))
                         })?;
                     }
-                    "scanner.log.fetch-wait-max-time-ms" => {
+                    "scanner.log.fetch.wait-max-time-ms" => {
                         config.scanner_log_fetch_wait_max_time_ms =
                             value.parse::<i32>().map_err(|e| {
                                 FlussError::new_err(format!(
                                     "Invalid value '{value}' for '{key}': {e}"
                                 ))
                             })?;
                     }
-                    "scanner.log.fetch-max-bytes-for-bucket" => {
+                    "scanner.log.fetch.max-bytes-for-bucket" => {
                         config.scanner_log_fetch_max_bytes_for_bucket =
                             value.parse::<i32>().map_err(|e| {
                                 FlussError::new_err(format!(

website/docs/user-guide/python/example/configuration.md

@@ -34,10 +34,10 @@ with await fluss.FlussConnection.create(config) as conn:
 | `remote-file.download-thread-num`     | Number of threads for remote log downloads                                            | `3`                |
 | `scanner.remote-log.read-concurrency` | Streaming read concurrency within a remote log file                                   | `4`                |
 | `scanner.log.max-poll-records`        | Max records returned in a single poll()                                               | `500`              |
-| `scanner.log.fetch-max-bytes`         | Maximum bytes per fetch response for LogScanner                                       | `16777216` (16 MB) |
-| `scanner.log.fetch-min-bytes`         | Minimum bytes the server must accumulate before returning a fetch response            | `1`                |
-| `scanner.log.fetch-wait-max-time-ms`  | Maximum time (ms) the server may wait to satisfy min-bytes                            | `500`              |
-| `scanner.log.fetch-max-bytes-for-bucket`| Maximum bytes per fetch response per bucket for LogScanner                          | `1048576` (1 MB)   |
+| `scanner.log.fetch.max-bytes`         | Maximum bytes per fetch response for LogScanner                                       | `16777216` (16 MB) |
+| `scanner.log.fetch.min-bytes`         | Minimum bytes the server must accumulate before returning a fetch response            | `1`                |
+| `scanner.log.fetch.wait-max-time-ms`  | Maximum time (ms) the server may wait to satisfy min-bytes                            | `500`              |
+| `scanner.log.fetch.max-bytes-for-bucket`| Maximum bytes per fetch response per bucket for LogScanner                          | `1048576` (1 MB)   |
 | `connect-timeout`                     | TCP connect timeout in milliseconds                                                   | `120000`           |
 | `security.protocol`                   | `PLAINTEXT` (default) or `sasl` for SASL auth                                        | `PLAINTEXT`        |
 | `security.sasl.mechanism`             | SASL mechanism (only `PLAIN` is supported)                                            | `PLAIN`            |