Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): support regions[].silent and update map data in tests #20566

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 6, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 6, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20566@4e84f15

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 6, 2024
src/component/helper/MapDraw.ts Outdated Show resolved Hide resolved
src/component/helper/MapDraw.ts Outdated Show resolved Hide resolved
src/component/helper/MapDraw.ts Outdated Show resolved Hide resolved
src/coord/geo/GeoModel.ts Outdated Show resolved Hide resolved
@Ovilia Ovilia marked this pull request as ready for review December 9, 2024 09:06
@Ovilia Ovilia added this to the 5.6.0 milestone Dec 9, 2024
@Ovilia Ovilia changed the title fix(map): update map data feat(map): support regions[].silent and update map data in tests Dec 9, 2024
@plainheart plainheart merged commit 70a5f3f into release-dev Dec 10, 2024
2 checks passed
Copy link

echarts-bot bot commented Dec 10, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-map branch December 10, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants