feat(geo): support styling region in original GeoJSON data #20564
Conversation
echarts-bot
bot
added
PR: author is committer
PR: awaiting doc
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20564@3ec7b26 |
| @@ -583,7 +583,7 @@ class SeriesData< | |||
| * Each item is exactly corresponding to a dimension. | |||
| */ | |||
| appendValues(values: any[][], names?: string[]): void { | |||
| const {start, end} = this._store.appendValues(values, names.length); | |||
| const {start, end} = this._store.appendValues(values, names && names.length); | |||
There was a problem hiding this comment.
This fixes a potential NPE.
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
This PR supersedes #20561. Apply
echartsStylein the Model instead of View.Demo
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to the 2nd test case in
test/geo-map.htmlandtest/map-nested.html.Others
Merging options
Other information