Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): support styling region in original GeoJSON data #20561

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Dec 5, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

To support directly presetting region style in original GeoJSON data. This can reduce one step to configure the geo option after registering GeoJSON map.

Demo

Details

Before: What was the problem?

Users can only configure the style in the geo.itemStyle option after registering a GeoJSON map.

After: How does it behave after the fixing?

Users can directly style regions in original GeoJSON data like a theme.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the 2nd test case in test/geo-map.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@plainheart plainheart added this to the 5.5.2 milestone Dec 5, 2024
@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. labels Dec 5, 2024
Copy link

echarts-bot bot commented Dec 5, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@plainheart plainheart marked this pull request as ready for review December 5, 2024 05:45
Copy link
Contributor

github-actions bot commented Dec 5, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20561@8f39773

@plainheart plainheart requested review from pissang and Ovilia December 5, 2024 06:41
@plainheart plainheart merged commit 5d1d34e into release-dev Dec 5, 2024
2 checks passed
@plainheart plainheart deleted the feat/geo/styling-in-geojson branch December 5, 2024 14:42
Copy link

echarts-bot bot commented Dec 5, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart removed this from the 5.5.2 milestone Dec 6, 2024
@plainheart plainheart removed the PR: awaiting doc Document changes is required for this PR. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants