Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): markLine symbolOffset can be a 2d array for both symbols #20491

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Nov 9, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add missing 2d array type for markLine.symbolOffset

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Link

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Nov 9, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.2 milestone Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20491@421069f

@Ovilia Ovilia merged commit 23efa66 into master Nov 15, 2024
2 checks passed
@Ovilia Ovilia deleted the fix/type/markLine-symbolOffset branch November 15, 2024 06:51
Copy link

echarts-bot bot commented Nov 15, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Markline symbolOffset array value does not work
2 participants