Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom): support compoundPath in custom series renderItem #20402

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 10, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR supports compoundPath in custom series renderItem. It can be used as:

renderItem(params, api) {
    return {
        type: 'compoundPath',
        shape: {
            paths: [rect, circle, ...]
        }
    }
}

Fixed issues

Details

Before: What was the problem?

compondPath is not supported so that we cannot make complex objects that looks like the union of shapes. If such shapes have opacity and intersection, it's hard to implement without a compoundPath.

After: How does it behave after the fixing?

compondPath is supported.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Oct 10, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).
You can use npm i zrender@npm:zrender-nightly@dev to update package.json.
If you have any question about this, please leave a comment and we will give you extra help on this.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20402@9fb4073

@Ovilia Ovilia merged commit 817ef5c into v6 Oct 16, 2024
2 checks passed
Copy link

echarts-bot bot commented Oct 16, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat-compoundPath branch October 16, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant