fix(tooltip): Tooltip textStyle lineHeight does not work in default #20398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20398@234fb4b |
Ovilia
requested changes
Oct 24, 2024
| @@ -151,9 +151,11 @@ function assembleFont(textStyleModel: Model<TooltipOption['textStyle']>): string | |||
|
|
|||
| cssText.push('font:' + textStyleModel.getFont()); | |||
|
|
|||
| // @ts-ignore, leave it to the tooltip refactor. | |||
| const lineHeight = textStyleModel.get('lineHeight') ?? Math.round(fontSize * 3 / 2); | |||
There was a problem hiding this comment.
Use zrUtil.retrive2 instead.
| textStyle: TooltipOption['textStyle'] | ||
| ) { | ||
| const lineHeight = textStyle.lineHeight; | ||
| if (lineHeight === undefined) { |
There was a problem hiding this comment.
Use == null to check undefined or null values.
|
Done |
Ovilia
requested changes
Oct 28, 2024
| @@ -46,7 +46,7 @@ function getTooltipLineHeight( | |||
| textStyle: TooltipOption['textStyle'] | |||
| ) { | |||
| const lineHeight = textStyle.lineHeight; | |||
| if (lineHeight === undefined) { | |||
| if (lineHeight === undefined || lineHeight === null) { | |||
There was a problem hiding this comment.
Use lineHeight == null should be enough.
Ovilia
approved these changes
Oct 30, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#20391
Details
Before: What was the problem?
lineHeight not work
After: How does it behave after the fixing?
add line-height in css
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information