Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: matrix coordinate #19807
base: next
Are you sure you want to change the base?
feat: matrix coordinate #19807
Changes from 12 commits
ecd2ff0
780dd4b
3c1dcb4
ce4530f
55883fc
ef9c3bd
0b90a95
ce5fa43
9b1c9a0
859ab1d
0daaae1
e510f3e
0b3f14b
9d1b48d
6e8c626
b0529f9
8bedb78
ab3efd3
6fe5d69
31295e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These borders may overlap and cause a darker border color. I'm not sure if we should provide a similar ability like the CSS table property
border-collapse
. It looks not easy to implement that feature.And the chart seems rendering unexpectedly if I set the width of both the outer border and inner border to
0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The border won't be darker unless the opacity of borderColors are not 1. I personally think providing a
border-collapse
like mechanism is over-kill because then, we should also implement other features like border widths and colors being different values at four sides. This should bring much work to implement it robustly. The reason why I choose to render rectangles with background and border is that it would be more difficult to think which option controls which border line.The image you provided is as expected. You should add
x.itemStyle.borderWidth: 0
andy.itemStyle.borderWidth: 0
if you want to remove those rest borders.