Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbox): use default boundaryGap when switching the line & bar series by the toolbox component #19509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(toolbox): use default boundaryGap when switching the line & bar series by the toolbox component #19509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/component/toolbox/feature/MagicType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class MagicType extends ToolboxFeature<ToolboxMagicTypeFeatureOption> {
zrUtil.defaults(newSeriesOpt, seriesModel.option);
(newOption.series as SeriesOption[]).push(newSeriesOpt);
}
// Modify boundaryGap
// Modify series
const coordSys = seriesModel.coordinateSystem;
if (coordSys && coordSys.type === 'cartesian2d' && (type === 'line' || type === 'bar')) {
const categoryAxis = coordSys.getAxesByScale('ordinal')[0];
Expand All @@ -130,7 +130,6 @@ class MagicType extends ToolboxFeature<ToolboxMagicTypeFeatureOption> {
for (let i = 0; i <= axisIndex; i++) {
(newOption[axisType] as any)[axisIndex] = (newOption[axisType] as any)[axisIndex] || {};
}
(newOption[axisType] as any)[axisIndex].boundaryGap = type === 'bar';
}
}
};
Expand Down