-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(brush): support brush selection on line series #19193
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution! |
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19193@632e106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please add a test case according to the wiki
Hello, how can I use it in JavaScript. |
Hi! I need this option |
I think lines should also be gray when out of range. This PR only makes item gray. @alxnddr Please update the implement to make sure the lines are also working as expected. |
That's the PR I need at the moment |
I have a branch open with these changes and I've added a test -- if you can point me in the right direction of where to set the line color (I have a hunch I need to use a rectangular selection in the |
@Ovilia any update on this? |
Brief Information
This pull request is in the type of:
What does this PR do?
This PR adds the support brushing selection to
line
series. Previously,This pull requests adds
brushSelector
to the LineSeriesFixed issues
Details
Before: What was the problem?
brushselected
event returned an emptydataIndex
array which makes it hard to figure out which points are selected with brushing.After: How does it behave after the fixing?
LineSeriesModel
implementsbrushSelector
method where it gets point coordinates bydataIndex
and then uses brush selector to understand if the point should be selected.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information