Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(brush): support brush selection on line series #19193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxnddr
Copy link

@alxnddr alxnddr commented Oct 11, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR adds the support brushing selection to line series. Previously,
This pull requests adds brushSelector to the LineSeries

Fixed issues

Details

Before: What was the problem?

brushselected event returned an empty dataIndex array which makes it hard to figure out which points are selected with brushing.

After: How does it behave after the fixing?

LineSeriesModel implements brushSelector method where it gets point coordinates by dataIndex and then uses brush selector to understand if the point should be selected.

Screenshot 2023-10-11 at 8 38 18 PM

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 11, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@echarts-bot
Copy link

echarts-bot bot commented Oct 11, 2023

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Oct 11, 2023
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Oct 12, 2023
@alxnddr alxnddr changed the title support brush selection on line series feat(brush): support brush selection on line series Oct 13, 2023
@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19193@632e106

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please add a test case according to the wiki

@yongesen
Copy link

yongesen commented Dec 8, 2023

Hello, how can I use it in JavaScript.

@VladSolyony
Copy link

Hi!

I need this option

@spuyet
Copy link

spuyet commented Jan 17, 2024

@alxnddr @Ovilia any news about this PR being merged ?

@chadallera1993
Copy link

@alxnddr @Ovilia any chance we can get this PR merged soon?

@Ovilia
Copy link
Contributor

Ovilia commented Feb 5, 2024

4c94502351362f443823516f27102075

I think lines should also be gray when out of range. This PR only makes item gray. @alxnddr Please update the implement to make sure the lines are also working as expected.

@iago-f-s-e
Copy link

That's the PR I need at the moment

@kateEcobb
Copy link

I have a branch open with these changes and I've added a test -- if you can point me in the right direction of where to set the line color (I have a hunch I need to use a rectangular selection in the brushSelector) I can finish this pr. cc @Ovilia

@HJK181
Copy link

HJK181 commented Nov 20, 2024

@Ovilia any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants