From 77a3723716341e33767495d587341fd85202eef3 Mon Sep 17 00:00:00 2001
From: Said Nukhulov <nukhulovsm@yandex.ru>
Date: Tue, 7 Nov 2023 01:01:05 +0300
Subject: [PATCH 1/2] feat(sampler): add min-max sampler function

---
 src/processor/dataSample.ts | 18 +++++++++++++++++-
 src/util/types.ts           |  2 +-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/processor/dataSample.ts b/src/processor/dataSample.ts
index 28579a652e..cbd370f2ba 100644
--- a/src/processor/dataSample.ts
+++ b/src/processor/dataSample.ts
@@ -61,6 +61,22 @@ const samplers: Dictionary<Sampler> = {
         // NaN will cause illegal axis extent.
         return isFinite(min) ? min : NaN;
     },
+    minmax: function (frame) {
+        let turningPointAbsoluteValue = -Infinity;
+        let turningPointOriginalValue = -Infinity;
+
+        for (let i = 0; i < frame.length; i++) {
+            const originalValue = frame[i];
+            const absoluteValue = Math.abs(originalValue);
+
+            if (absoluteValue > turningPointAbsoluteValue) {
+                turningPointAbsoluteValue = absoluteValue;
+                turningPointOriginalValue = originalValue;
+            }
+        }
+
+        return isFinite(turningPointOriginalValue) ? turningPointOriginalValue : NaN;
+    },
     // TODO
     // Median
     nearest: function (frame) {
@@ -116,4 +132,4 @@ export default function dataSample(seriesType: string): StageHandler {
             }
         }
     };
-}
\ No newline at end of file
+}
diff --git a/src/util/types.ts b/src/util/types.ts
index 4a212872dd..c7b0c4ef36 100644
--- a/src/util/types.ts
+++ b/src/util/types.ts
@@ -1675,7 +1675,7 @@ export interface SeriesStackOptionMixin {
 type SamplingFunc = (frame: ArrayLike<number>) => number;
 
 export interface SeriesSamplingOptionMixin {
-    sampling?: 'none' | 'average' | 'min' | 'max' | 'sum' | 'lttb' | SamplingFunc
+    sampling?: 'none' | 'average' | 'min' | 'max' | 'minmax' | 'sum' | 'lttb' | SamplingFunc
 }
 
 export interface SeriesEncodeOptionMixin {

From 4a633400807cae8392bf1fef88e32274bbe865bb Mon Sep 17 00:00:00 2001
From: Said Nukhulov <nukhulovsm@yandex.ru>
Date: Sat, 25 Nov 2023 21:06:45 +0300
Subject: [PATCH 2/2] feat(sampler): add min-max sampler function

---
 test/line-sampling.html | 113 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 113 insertions(+)

diff --git a/test/line-sampling.html b/test/line-sampling.html
index ea8382734a..c288d893d1 100644
--- a/test/line-sampling.html
+++ b/test/line-sampling.html
@@ -36,6 +36,7 @@
 
         <div id="main0"></div>
         <div id="main1"></div>
+        <div id="main2"></div>
 
         <script>
             require([
@@ -290,5 +291,117 @@
                 });
             });
         </script>
+
+        <script>
+            require([
+                'echarts'
+            ], function (echarts) {
+                const frequency = 70;
+                const magnitude = 20;
+                const firstSineData = [];
+                const secondSineData = [];
+                const firstSineOffset = 0;
+                const secondSineOffset = 50;
+                const start = new Date('2021-03-03T15:30:00.000Z');
+                for (let i = 0; i < 1960; i++) {
+                    const date = new Date(start.getTime() + i);
+                    const time = i / 1000;
+                    let value = (Math.sin( 2 * Math.PI * frequency * time) * magnitude).toFixed(3);
+                    if (i < 639 || i > 943) {
+                        firstSineData.push([date, (value + firstSineOffset)]);
+                        secondSineData.push([date, -(value - secondSineOffset)]);
+                    }
+                    else if (i === 934) {
+                        firstSineData.push([date, null]);
+                        secondSineData.push([date, null]);
+                    }
+                }
+
+                const option = {
+                    title: { text: "Data" },
+                    tooltip: { trigger: "axis", axisPointer: { animation: true } },
+                    legend: {
+                        data: ["sin(x•π•0.14)", "50 - sin(x•π•0.14)"],
+                    },
+                    dataZoom: [
+                        { realtime: true, xAxisIndex: [0, 1], filterMode: "weakFilter" },
+                        { type: "inside", realtime: true, xAxisIndex: [0, 1] },
+                    ],
+                    toolbox: { feature: { saveAsImage: {}, restore: {} } },
+                    xAxis: { type: "time" },
+                    yAxis: [
+                        {
+                            type: "value",
+                            position: "left",
+                            name: "time, s",
+                            min: -50,
+                            max: 100,
+                            _medium: "sin(x•π•0.14)"
+                        },
+                        {
+                            type: "value",
+                            position: "left",
+                            name: "time, s",
+                            min: -50,
+                            max: 100,
+                            _medium: "50 - sin(x•π•0.14)"
+                        }
+                    ],
+                    series: [
+                        {
+                            name: "sin(x•π•0.14)",
+                            type: "line",
+                            step: "start",
+                            showSymbol: false,
+                            yAxisIndex: 0,
+                            sampling: "minmax",
+                            connectNulls: false,
+                            data: firstSineData
+                        },
+                        {
+                            name: "50 - sin(x•π•0.14)",
+                            type: "line",
+                            step: "start",
+                            showSymbol: false,
+                            yAxisIndex: 1,
+                            sampling: "minmax",
+                            connectNulls: false,
+                            data: secondSineData
+                        }
+                    ]
+                };
+
+                var chart1 = testHelper.create(echarts, 'main2', {
+                    title: [
+                        'Sampling with minmax, test **connectNulls**',
+                        'toggle connectNulls value or switch setting, check it.'
+                    ],
+                    option,
+                    width: 600,
+                    height: 400,
+                    buttons: [
+                        {
+                            text: 'toggle connectNulls value',
+                            onclick: function () {
+                                option.series.forEach((s) => {
+                                    s.connectNulls = !s.connectNulls;
+                                })
+                                chart1.setOption(option);
+                            }
+                        },
+                        {
+                            text: 'switch sampling between minmax and lttb',
+                            onclick: function () {
+                                option.series.forEach((s) => {
+                                    s.sampling = s.sampling === 'minmax' ? 'lttb' : 'minmax';
+                                })
+                                chart1.setOption(option);
+                                console.log('current setting:', option.series[0].sampling);
+                            }
+                        }
+                    ]
+                });
+            });
+        </script>
     </body>
 </html>