Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sampler): add min-max sampler function #374

Merged
merged 3 commits into from
Nov 30, 2023
Merged

feat(sampler): add min-max sampler function #374

merged 3 commits into from
Nov 30, 2023

Conversation

snukhulov
Copy link
Contributor

@snukhulov snukhulov commented Nov 7, 2023 •
edited by plainheart
Loading

Related PR: apache/echarts#19279

@snukhulov snukhulov mentioned this pull request Nov 7, 2023
Merged
8 tasks
@Ovilia Ovilia changed the base branch from master to dev November 27, 2023 08:53
@Ovilia Ovilia changed the base branch from dev to master November 27, 2023 08:54
@Ovilia Ovilia changed the base branch from master to dev November 27, 2023 08:54
Ovilia
Ovilia requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I failed to make a commit to this PR. Can you help add the Chinese doc? The content is:

+ `'min'` 取过滤点的最小值
+ `'max'` 取过滤点的最大值
+ `'minmax'` 取过滤点绝对值的最大极值

@snukhulov
Copy link
Contributor Author

Somehow I failed to make a commit to this PR. Can you help add the Chinese doc? The content is:

+ `'min'` 取过滤点的最小值
+ `'max'` 取过滤点的最大值
+ `'minmax'` 取过滤点绝对值的最大极值

Sure, done

@plainheart plainheart merged commit 0accd2f into apache:dev Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia requested changes

@plainheart plainheart plainheart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snukhulov @Ovilia @plainheart