Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Remove spring-boot-starter-cache dependency #16507

Closed
2 of 3 tasks
ruanwenjun opened this issue Aug 26, 2024 · 6 comments · Fixed by #16593
Closed
2 of 3 tasks

[Improvement] Remove spring-boot-starter-cache dependency #16507

ruanwenjun opened this issue Aug 26, 2024 · 6 comments · Fixed by #16593
Assignees
Labels
good first issue good first issue

Comments

@ruanwenjun
Copy link
Member

ruanwenjun commented Aug 26, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

This is not used anymore.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ruanwenjun ruanwenjun added the good first issue good first issue label Aug 26, 2024
@apache apache deleted a comment Aug 26, 2024
@binitshrest
Copy link
Contributor

I am interested in solving this issue.

@SbloodyS
Copy link
Member

SbloodyS commented Sep 2, 2024

I am interested in solving this issue.

I've assigned to you. Looking forward to your contribution.

@binitshrest
Copy link
Contributor

I am interested in solving this issue.

I've assigned to you. Looking forward to your contribution.

Hi, I have started working on this contributions.
This applications is not running in my system due to spotless plugin error. I tried upgrading but it says it is missing some class file i.e com/sun/source/tree/Tree

I have JDK 17 installed.

@SbloodyS
Copy link
Member

SbloodyS commented Sep 3, 2024

Hi, I have started working on this contributions. This applications is not running in my system due to spotless plugin error. I tried upgrading but it says it is missing some class file i.e com/sun/source/tree/Tree

I have JDK 17 installed.

You can refer to the docs in https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/development-environment-setup.md

@binitshrest
Copy link
Contributor

I have checked the docs and i have installed the required OS and particular installation. Let me work from now on. I will keep you posted.

@binitshrest
Copy link
Contributor

After careful observation about dependency spring-boot-starter-cache depedency and apllication.properties it has already been removed and i did some more few work understanding the code base and removed other extra dependencies that includes annotations like cacheable and cacheconfig. I removed and i ran the standalone server. It was running without any error. I am ready to do pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants