Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [dolphinscheduler-master] Can't stop the subProcess instance successfully via STOP its master process instance #16467

Open
3 tasks done
topsli opened this issue Aug 15, 2024 · 1 comment · May be fixed by #16470
Open
3 tasks done

[Bug] [dolphinscheduler-master] Can't stop the subProcess instance successfully via STOP its master process instance #16467

topsli opened this issue Aug 15, 2024 · 1 comment · May be fixed by #16470
Assignees
@topsli
Labels
bug Something isn't working help wanted Extra attention is needed priority:middle

Comments

@topsli
Copy link
Contributor

topsli commented Aug 15, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Can't stop the subProcess instance successfully via STOP its master process instance

What you expected to happen

Expect stop all the subProcess instance successful via STOP the master process instance

How to reproduce

1.create a workflow, its need a SubProcess task and refer it to another workflow
2. start up this master workflow
3. try to STOP it
4. the master process instance stopped, but the subPorcess instance is still running and the task of this subProcess instance also running to. (May be you need to check its state in DB if the UI haven't shows subProcess instances)

Anything else

No response

Version

3.2.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@topsli topsli added bug Something isn't working Waiting for reply Waiting for reply labels Aug 15, 2024
@SbloodyS SbloodyS added help wanted Extra attention is needed priority:middle and removed Waiting for reply Waiting for reply labels Aug 15, 2024
@SbloodyS SbloodyS linked a pull request Aug 15, 2024 that will close this issue
Open
@topsli
Copy link
Contributor Author

topsli commented Aug 15, 2024

  1. This issue is at the method of putMasterTaskExecuteRunnable in class MasterTaskExecutorHolder , which is no usages. But in the operate method of LogicITaskInstanceKillOperationFunction class, we can find its use MasterTaskExecutorHolder.getMasterTaskExecutor(taskInstanceId) to get masterTaskExecutor , and then to use masterTaskExecutor to cancel task.
    So, it's should put masterTaskExecutor first in class MasterTaskExecutorHolder .

2.Another point of this issue at the method of sendToSubProcess in class SubWorkflowLogicTask, when new WorkflowInstanceStateChangeEvent object, it should use subProcessInstance.getId() to set sourceProcessInstanceId.

3.The DynamicLogicTask have same issue, resolve solution same to the SubWorkflowLogicTask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topsli topsli

Labels
bug Something isn't working help wanted Extra attention is needed priority:middle
Projects
None yet
Milestone
No milestone
2 participants
@topsli @SbloodyS