Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-34] Change required_approving_review_count to 2 #15913

Closed
2 tasks done
Tracked by #14102
ruanwenjun opened this issue Apr 25, 2024 · 0 comments · Fixed by #15914
Closed
2 tasks done
Tracked by #14102

[DSIP-34] Change required_approving_review_count to 2 #15913

ruanwenjun opened this issue Apr 25, 2024 · 0 comments · Fixed by #15914
Assignees

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

Right now, the minimal approve count is 1 in DS, this means once a pr receive an approve, then this PR can be merged. In fact, in most of merged PR, the approval is one.

While I don't agree with change the minimal ap to 2, currently only 1 ap can merge PRs leading to a lot of PRs being merged in a hurry. This make the project get a lot of changes only a small number of people(Maybe only one people) want.

So it's need to change the required_approving_review_count be larger than one.

Design Detail

Change required_approving_review_count in .asf.yaml

Compatibility, Deprecation, and Migration Plan

Compatibility

Test Plan

No

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant