You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had searched in the DSIP and found no similar DSIP.
Motivation
Right now, the minimal approve count is 1 in DS, this means once a pr receive an approve, then this PR can be merged. In fact, in most of merged PR, the approval is one.
While I don't agree with change the minimal ap to 2, currently only 1 ap can merge PRs leading to a lot of PRs being merged in a hurry. This make the project get a lot of changes only a small number of people(Maybe only one people) want.
So it's need to change the required_approving_review_count be larger than one.
Design Detail
Change required_approving_review_count in .asf.yaml
Search before asking
Motivation
Right now, the minimal approve count is 1 in DS, this means once a pr receive an approve, then this PR can be merged. In fact, in most of merged PR, the approval is one.
While I don't agree with change the minimal ap to 2, currently only 1 ap can merge PRs leading to a lot of PRs being merged in a hurry. This make the project get a lot of changes only a small number of people(Maybe only one people) want.
So it's need to change the required_approving_review_count be larger than one.
Design Detail
Change
required_approving_review_count
in.asf.yaml
Compatibility, Deprecation, and Migration Plan
Compatibility
Test Plan
No
Code of Conduct
The text was updated successfully, but these errors were encountered: