Skip to content

Improve error message in sqllogictest with <slt:ignore> marker #18878

@2010YOUY01

Description

@2010YOUY01

Is your feature request related to a problem or challenge?

Follow up to #18857

With <slt:ignore> feature, if the actual and expected is not matched, we got error message like

2. query result mismatch:
[SQL] select * from generate_series(3);
[Diff] (-expected|+actual)
-   <slt:ignore>
+   0
    1
-   3<slt:ignore>
+   2
    3
at /Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/slt_features.slt:84

The first diff is a false positive, and the second one is expected. It would be great to suppress the 1st diff.

Also, the error message rendering and the actual validation for sqllogictest seems to live in two different places, it would be better to combine them.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions