try_arithmetic_impl

coderfender · coderfender · commit bd002fac6a8e · 2025-08-12T12:16:12.000-07:00
diff --git a/native/spark-expr/src/math_funcs/checked_arithmetic.rs b/native/spark-expr/src/math_funcs/checked_arithmetic.rs
@@ -17,7 +17,6 @@
 
 use arrow::array::{Array, ArrowNativeTypeOp, PrimitiveArray, PrimitiveBuilder};
 use arrow::array::{ArrayRef, AsArray};
-use std::fmt::format;
 
 use arrow::datatypes::{ArrowPrimitiveType, DataType, Int32Type, Int64Type};
 use datafusion::common::DataFusionError;
@@ -71,7 +70,12 @@ where
                 }
             }
         }
-        _ => Err(format!("Unsupported operation: {}", op)).unwrap(),
+        _ => {
+            return Err(DataFusionError::Internal(format!(
+                "Unsupported operation: {:?}",
+                op
+            )))
+        }
     }
 
     Ok(Arc::new(builder.finish()) as ArrayRef)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`
`18`	`18`	`use arrow::array::{Array, ArrowNativeTypeOp, PrimitiveArray, PrimitiveBuilder};`
`19`	`19`	`use arrow::array::{ArrayRef, AsArray};`
`20`		`-use std::fmt::format;`
`21`	`20`
`22`	`21`	`use arrow::datatypes::{ArrowPrimitiveType, DataType, Int32Type, Int64Type};`
`23`	`22`	`use datafusion::common::DataFusionError;`
`@@ -71,7 +70,12 @@ where`
`71`	`70`	`}`
`72`	`71`	`}`
`73`	`72`	`}`
`74`		`- _ => Err(format!("Unsupported operation: {}", op)).unwrap(),`
	`73`	`+ _ => {`
	`74`	`+ return Err(DataFusionError::Internal(format!(`
	`75`	`+ "Unsupported operation: {:?}",`
	`76`	`+ op`
	`77`	`+ )))`
	`78`	`+ }`
`75`	`79`	`}`
`76`	`80`
`77`	`81`	`Ok(Arc::new(builder.finish()) as ArrayRef)`