Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Bundled Thrift fails configuring on Windows #45628

Open
pitrou opened this issue Feb 25, 2025 · 2 comments
Open

[C++] Bundled Thrift fails configuring on Windows #45628

pitrou opened this issue Feb 25, 2025 · 2 comments

Comments

@pitrou
Copy link
Member

pitrou commented Feb 25, 2025

Describe the bug, including details regarding any error messages, version, and platform.

After updating to latest git main, I fail building with bundled Thrift on Windows. Here is the cmake + ninja log:
https://gist.github.com/pitrou/41d25851fc624849b38b1f89d298f9cf

Component(s)

C++

@pitrou
Copy link
Member Author

pitrou commented Feb 25, 2025

cc @kou

@kou
Copy link
Member

kou commented Feb 26, 2025

Could you try this?

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 9b531c8d5a..ef7b0b008f 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1773,9 +1773,10 @@ macro(build_thrift)
   if(DEFINED BOOST_ROOT)
     list(APPEND THRIFT_CMAKE_ARGS "-DBOOST_ROOT=${BOOST_ROOT}")
   endif()
-  if(DEFINED Boost_INCLUDE_DIR)
-    list(APPEND THRIFT_CMAKE_ARGS "-DBoost_INCLUDE_DIR=${Boost_INCLUDE_DIR}")
-  endif()
+  list(APPEND
+       THRIFT_CMAKE_ARGS
+       "-DBoost_INCLUDE_DIR=$<TARGET_PROPERTY:Boost::headers,INTERFACE_INCLUDE_DIRECTORIES>"
+  )
   if(DEFINED Boost_NAMESPACE)
     list(APPEND THRIFT_CMAKE_ARGS "-DBoost_NAMESPACE=${Boost_NAMESPACE}")
   endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants