Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Acero] High contention in Swiss join build phase #45611

Open
zanmato1984 opened this issue Feb 24, 2025 · 0 comments
Open

[C++][Acero] High contention in Swiss join build phase #45611

zanmato1984 opened this issue Feb 24, 2025 · 0 comments
Assignees

Comments

@zanmato1984
Copy link
Contributor

zanmato1984 commented Feb 24, 2025

When benchmarking hash join build phase using this benchmark, I saw significant contention when the concurrency is high. As the following flame graph shows, function PartitionLocks::AcquirePartitionLock (the long yellow bar in the middle) takes quite a lot CPU time (thanks to that it is using spin lock rather than mutex, otherwise it may not be so eye-catching).

We should consider optimizing this.

Image

Component(s)

C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant