Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Python] test-conda-python-3.11-hypothesis fails with 'Python binding for RankQuantileOptions not exposed' #45380

Closed
raulcd opened this issue Jan 29, 2025 · 1 comment
Closed

[CI][Python] test-conda-python-3.11-hypothesis fails with 'Python binding for RankQuantileOptions not exposed' #45380

raulcd opened this issue Jan 29, 2025 · 1 comment
Assignees
@raulcd
Labels
Component: Continuous Integration Component: Python Type: bug
Milestone
20.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jan 29, 2025

Describe the bug, including details regarding any error messages, version, and platform.

The test-conda-python-3.11-hypothesis job fails with the following error:

==================================== ERRORS ====================================
__ ERROR collecting opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow __
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/compute.py:209: in _get_options_class
    return globals()[class_name]
E   KeyError: 'RankQuantileOptions'

During handling of the above exception, another exception occurred:
opt/conda/envs/arrow/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
opt/conda/envs/arrow/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:184: in exec_module
    exec(co, module.__dict__)
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/conftest.py:135: in <module>
    import pyarrow.acero  # noqa
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/acero.py:26: in <module>
    from pyarrow.compute import Expression, field
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/compute.py:336: in <module>
    _make_global_functions()
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/compute.py:333: in _make_global_functions
    g[cpp_name] = g[name] = _wrap_function(name, func)
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/compute.py:292: in _wrap_function
    options_class = _get_options_class(func)
opt/conda/envs/arrow/lib/python3.11/site-packages/pyarrow/compute.py:211: in _get_options_class
    warnings.warn("Python binding for {} not exposed"
E   RuntimeWarning: Python binding for RankQuantileOptions not exposed
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

Component(s)

Continuous Integration, Python
@Linchin Linchin mentioned this issue Jan 29, 2025
Closed
@raulcd raulcd self-assigned this Jan 30, 2025
raulcd added a commit to raulcd/arrow that referenced this issue Jan 30, 2025
@raulcd
apacheGH-45380: [Python] Expose RankQuantileOptions to Python
ff3a84d
@github-actions github-actions bot mentioned this issue Jan 30, 2025
Merged
pitrou added a commit that referenced this issue Feb 5, 2025
@raulcd @pitrou
GH-45380: [Python] Expose RankQuantileOptions to Python (#45392)
0556905 
### Rationale for this change

`RankQuantileOptions` are currently not exposed on Pyarrow and CI job breaks when `-W error` is used.

### What changes are included in this PR?

Expose `RankQuantileOptions` and test options and kernel from pyarrow.

It also includes some minor refactor for the unwrap sort keys logic to move it into a common function.

### Are these changes tested?

Yes

### Are there any user-facing changes?

The options for the new kernel are exposed on pyarrow.
* GitHub Issue: #45380

Lead-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 20.0.0 milestone Feb 5, 2025
@pitrou
Copy link
Member

pitrou commented Feb 5, 2025

Issue resolved by pull request 45392
#45392

@pitrou pitrou closed this as completed Feb 5, 2025
@Linchin Linchin mentioned this issue Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Component: Python Type: bug
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@raulcd @pitrou