Commit b3dcb6d
authored
### Rationale for this change
- When writing Arrow timestamps to Parquet, timestamp values are multiplied to convert units
- This multiplication was performed without overflow checking which can silently write corrupt data.
### What changes are included in this PR?
- Use MultiplyWithOverflowGeneric to handle/detect overflow
### Are these changes tested?
- Yes
### Are there any user-facing changes?
- Yes
* GitHub Issue: #47657
Authored-by: Arnav Balyan <arnavbalyan1@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
1 parent caf7f5b commit b3dcb6d
2 files changed
Lines changed: 43 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2178 | 2178 | | |
2179 | 2179 | | |
2180 | 2180 | | |
| 2181 | + | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
| 2195 | + | |
| 2196 | + | |
| 2197 | + | |
| 2198 | + | |
| 2199 | + | |
| 2200 | + | |
| 2201 | + | |
| 2202 | + | |
| 2203 | + | |
| 2204 | + | |
| 2205 | + | |
| 2206 | + | |
| 2207 | + | |
| 2208 | + | |
| 2209 | + | |
| 2210 | + | |
| 2211 | + | |
| 2212 | + | |
| 2213 | + | |
| 2214 | + | |
| 2215 | + | |
2181 | 2216 | | |
2182 | 2217 | | |
2183 | 2218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
2352 | 2353 | | |
2353 | 2354 | | |
2354 | 2355 | | |
2355 | | - | |
| 2356 | + | |
| 2357 | + | |
| 2358 | + | |
| 2359 | + | |
| 2360 | + | |
| 2361 | + | |
| 2362 | + | |
2356 | 2363 | | |
2357 | 2364 | | |
2358 | 2365 | | |
| |||
0 commit comments