GH-46714: [C++] Use hidden symbol visibility in Meson configuration (#46715)

### Rationale for this change

This will eventually make it easier to support Windows through the Meson configuration, while also providing the documented benefits of hidden symbol visibility

### What changes are included in this PR?

Meson libraries have been set to use hidden symbol visibility, and corresponding definitions have been updated to use the ARROW_EXPORT macro

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: #46714

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>

Author: WillAyd

cpp/src/arrow/acero/meson.build

@@ -81,6 +81,7 @@ arrow_acero_lib = library(
     'arrow-acero',
     sources: arrow_acero_srcs,
     dependencies: [arrow_compute_dep, arrow_dep],
+    gnu_symbol_visibility: 'hidden',
 )
 
 arrow_acero_dep = declare_dependency(link_with: [arrow_acero_lib])

cpp/src/arrow/array/array_base.h

@@ -265,10 +265,10 @@ class ARROW_EXPORT Array {
 
  private:
   ARROW_DISALLOW_COPY_AND_ASSIGN(Array);
-
-  ARROW_FRIEND_EXPORT friend void PrintTo(const Array& x, std::ostream* os);
 };
 
+ARROW_EXPORT void PrintTo(const Array& x, std::ostream* os);
+
 static inline std::ostream& operator<<(std::ostream& os, const Array& x) {
   os << x.ToString();
   return os;

cpp/src/arrow/compute/expression.cc

@@ -219,7 +219,7 @@ void PrintTo(const Expression& expr, std::ostream* os) {
 }
 
 bool Expression::Equals(const Expression& other) const {
-  if (Identical(*this, other)) return true;
+  if (Expression::Identical(*this, other)) return true;
 
   if (impl_ == nullptr || other.impl_ == nullptr) return false;
 
@@ -260,7 +260,9 @@ bool Expression::Equals(const Expression& other) const {
   return false;
 }
 
-bool Identical(const Expression& l, const Expression& r) { return l.impl_ == r.impl_; }
+bool Expression::Identical(const Expression& l, const Expression& r) {
+  return l.impl_ == r.impl_;
+}
 
 size_t Expression::hash() const {
   if (auto lit = literal()) {
@@ -1452,7 +1454,7 @@ Result<Expression> SimplifyWithGuarantee(Expression expr,
                                   return inequality->Simplify(std::move(expr));
                                 }));
 
-      if (Identical(simplified, expr)) continue;
+      if (Expression::Identical(simplified, expr)) continue;
 
       expr = std::move(simplified);
       RETURN_NOT_OK(CanonicalizeAndFoldConstants());
@@ -1463,7 +1465,7 @@ Result<Expression> SimplifyWithGuarantee(Expression expr,
           auto simplified,
           SimplifyIsValidGuarantee(std::move(expr), *CallNotNull(guarantee)));
 
-      if (Identical(simplified, expr)) continue;
+      if (Expression::Identical(simplified, expr)) continue;
 
       expr = std::move(simplified);
       RETURN_NOT_OK(CanonicalizeAndFoldConstants());

cpp/src/arrow/compute/expression.h

@@ -132,11 +132,11 @@ class ARROW_EXPORT Expression {
   explicit Expression(Datum literal);
   explicit Expression(Parameter parameter);
 
+  static bool Identical(const Expression& l, const Expression& r);
+
  private:
   using Impl = std::variant<Datum, Parameter, Call>;
   std::shared_ptr<Impl> impl_;
-
-  ARROW_FRIEND_EXPORT friend bool Identical(const Expression& l, const Expression& r);
 };
 
 inline bool operator==(const Expression& l, const Expression& r) { return l.Equals(r); }

cpp/src/arrow/compute/expression_test.cc

@@ -990,7 +990,7 @@ TEST(Expression, ExecuteDictionaryTransparent) {
 void ExpectIdenticalIfUnchanged(Expression modified, Expression original) {
   if (modified == original) {
     // no change -> must be identical
-    EXPECT_TRUE(Identical(modified, original)) << "  " << original.ToString();
+    EXPECT_TRUE(Expression::Identical(modified, original)) << "  " << original.ToString();
   }
 }
 

cpp/src/arrow/compute/kernels/ree_util_internal.h

@@ -27,6 +27,7 @@
 #include "arrow/array/data.h"
 #include "arrow/compute/exec.h"
 #include "arrow/compute/kernel.h"
+#include "arrow/compute/visibility.h"
 #include "arrow/result.h"
 #include "arrow/status.h"
 #include "arrow/type_traits.h"
@@ -346,7 +347,7 @@ Result<std::shared_ptr<ArrayData>> PreallocateRunEndsArray(
 /// \param has_validity_buffer a validity buffer must be allocated
 /// \param length the length of the values array
 /// \param data_buffer_size the size of the data buffer for string and binary types
-Result<std::shared_ptr<ArrayData>> PreallocateValuesArray(
+ARROW_COMPUTE_EXPORT Result<std::shared_ptr<ArrayData>> PreallocateValuesArray(
     const std::shared_ptr<DataType>& value_type, bool has_validity_buffer, int64_t length,
     MemoryPool* pool, int64_t data_buffer_size);
 
@@ -362,7 +363,7 @@ Result<std::shared_ptr<ArrayData>> PreallocateValuesArray(
 /// data.child_data[1].buffer[0] != NULLPTR
 ///
 /// \param data_buffer_size the size of the data buffer for string and binary types
-Result<std::shared_ptr<ArrayData>> PreallocateREEArray(
+ARROW_COMPUTE_EXPORT Result<std::shared_ptr<ArrayData>> PreallocateREEArray(
     std::shared_ptr<RunEndEncodedType> ree_type, bool has_validity_buffer,
     int64_t logical_length, int64_t physical_length, MemoryPool* pool,
     int64_t data_buffer_size);
@@ -377,7 +378,7 @@ Result<std::shared_ptr<ArrayData>> PreallocateREEArray(
 /// - run_ends fits in the run-end type without overflow
 void WriteSingleRunEnd(ArrayData* run_ends_data, int64_t run_end);
 
-Result<std::shared_ptr<ArrayData>> MakeNullREEArray(
+ARROW_COMPUTE_EXPORT Result<std::shared_ptr<ArrayData>> MakeNullREEArray(
     const std::shared_ptr<DataType>& run_end_type, int64_t logical_length,
     MemoryPool* pool);
 

cpp/src/arrow/compute/util.h

@@ -149,7 +149,7 @@ Result<Expression> ModifyExpression(Expression expr, const PreVisit& pre,
     ARROW_ASSIGN_OR_RAISE(auto modified_argument,
                           ModifyExpression(call->arguments[i], pre, post_call));
 
-    if (Identical(modified_argument, call->arguments[i])) {
+    if (Expression::Identical(modified_argument, call->arguments[i])) {
       continue;
     }
 

cpp/src/arrow/filesystem/azurefs_internal.h

@@ -70,7 +70,7 @@ enum class HierarchicalNamespaceSupport {
 /// account.
 /// \return kEnabled/kDisabled/kContainerNotFound (kUnknown is never
 /// returned).
-Result<HierarchicalNamespaceSupport> CheckIfHierarchicalNamespaceIsEnabled(
+ARROW_EXPORT Result<HierarchicalNamespaceSupport> CheckIfHierarchicalNamespaceIsEnabled(
     const Azure::Storage::Files::DataLake::DataLakeFileSystemClient& adlfs_client,
     const arrow::fs::AzureOptions& options);
 

cpp/src/arrow/filesystem/mockfs.cc

@@ -255,12 +255,12 @@ class MockFSInputStream : public io::BufferReader {
 
 }  // namespace
 
-std::ostream& operator<<(std::ostream& os, const MockDirInfo& di) {
+ARROW_EXPORT std::ostream& operator<<(std::ostream& os, const MockDirInfo& di) {
   return os << "'" << di.full_path << "' [mtime=" << di.mtime.time_since_epoch().count()
             << "]";
 }
 
-std::ostream& operator<<(std::ostream& os, const MockFileInfo& di) {
+ARROW_EXPORT std::ostream& operator<<(std::ostream& os, const MockFileInfo& di) {
   return os << "'" << di.full_path << "' [mtime=" << di.mtime.time_since_epoch().count()
             << ", size=" << di.data.length() << "]";
 }

cpp/src/arrow/meson.build

@@ -422,6 +422,8 @@ arrow_lib = library(
     include_directories: arrow_includes,
     dependencies: arrow_deps,
     install: true,
+    gnu_symbol_visibility: 'hidden',
+    cpp_shared_args: ['-DARROW_EXPORTING'],
 )
 
 arrow_dep = declare_dependency(
@@ -484,6 +486,7 @@ if needs_compute
         sources: arrow_compute_lib_sources,
         dependencies: arrow_dep,
         install: true,
+        cpp_shared_args: ['-DARROW_COMPUTE_EXPORTING'],
     )
     arrow_compute_dep = declare_dependency(
         link_with: arrow_compute_lib,