Skip to content

Commit 1f94910

Browse files
authored
GH-49252: [GLib] Deprecate Feather features (#49673)
### Rationale for this change We'll deprecate Feather V1 reader/writer. See also the discussion at https://lists.apache.org/thread/1npvnhjb1xwz09zh8vnd079zt2q4o08l . We can use IPC file reader/writer for Feather V2. ### What changes are included in this PR? * Add deprecation warnings to Feather features. * Use `GARROW_DEPRECATED()`/`GARROW_DEPRECATED_FOR()` instead of `G_GNUC_DEPRECATED()`/`G_GNUC_DEPRECATED_FOR()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #49252 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
1 parent 5ba5c3c commit 1f94910

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

c_glib/arrow-glib/input-stream.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ garrow_gio_input_stream_new(GInputStream *gio_input_stream);
180180

181181
#ifndef GARROW_DISABLE_DEPRECATED
182182
GARROW_AVAILABLE_IN_ALL
183-
G_GNUC_DEPRECATED
183+
GARROW_DEPRECATED
184184
GInputStream *
185185
garrow_gio_input_stream_get_raw(GArrowGIOInputStream *input_stream);
186186
#endif

c_glib/arrow-glib/output-stream.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ garrow_gio_output_stream_new(GOutputStream *gio_output_stream);
104104

105105
#ifndef GARROW_DISABLE_DEPRECATED
106106
GARROW_AVAILABLE_IN_ALL
107-
G_GNUC_DEPRECATED
107+
GARROW_DEPRECATED
108108
GOutputStream *
109109
garrow_gio_output_stream_get_raw(GArrowGIOOutputStream *output_stream);
110110
#endif

c_glib/arrow-glib/reader.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ garrow_record_batch_reader_get_schema(GArrowRecordBatchReader *reader);
6060

6161
#ifndef GARROW_DISABLE_DEPRECATED
6262
GARROW_AVAILABLE_IN_ALL
63-
G_GNUC_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
63+
GARROW_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
6464
GArrowRecordBatch *
6565
garrow_record_batch_reader_get_next_record_batch(GArrowRecordBatchReader *reader,
6666
GError **error);
6767
#endif
6868
#ifndef GARROW_DISABLE_DEPRECATED
6969
GARROW_AVAILABLE_IN_ALL
70-
G_GNUC_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
70+
GARROW_DEPRECATED_FOR(garrow_record_batch_reader_read_next)
7171
GArrowRecordBatch *
7272
garrow_record_batch_reader_read_next_record_batch(GArrowRecordBatchReader *reader,
7373
GError **error);
@@ -153,7 +153,7 @@ garrow_record_batch_file_reader_get_version(GArrowRecordBatchFileReader *reader)
153153

154154
#ifndef GARROW_DISABLE_DEPRECATED
155155
GARROW_AVAILABLE_IN_ALL
156-
G_GNUC_DEPRECATED_FOR(garrow_record_batch_file_reader_read_record_batch)
156+
GARROW_DEPRECATED_FOR(garrow_record_batch_file_reader_read_record_batch)
157157
GArrowRecordBatch *
158158
garrow_record_batch_file_reader_get_record_batch(GArrowRecordBatchFileReader *reader,
159159
guint i,
@@ -183,25 +183,30 @@ struct _GArrowFeatherFileReaderClass
183183
};
184184

185185
GARROW_AVAILABLE_IN_ALL
186+
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_file_reader_new)
186187
GArrowFeatherFileReader *
187188
garrow_feather_file_reader_new(GArrowSeekableInputStream *file, GError **error);
188189

189190
GARROW_AVAILABLE_IN_ALL
191+
GARROW_DEPRECATED_IN_24_0
190192
gint
191193
garrow_feather_file_reader_get_version(GArrowFeatherFileReader *reader);
192194

193195
GARROW_AVAILABLE_IN_ALL
196+
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all)
194197
GArrowTable *
195198
garrow_feather_file_reader_read(GArrowFeatherFileReader *reader, GError **error);
196199

197200
GARROW_AVAILABLE_IN_ALL
201+
GARROW_DEPRECATED_IN_24_0
198202
GArrowTable *
199203
garrow_feather_file_reader_read_indices(GArrowFeatherFileReader *reader,
200204
const gint *indices,
201205
guint n_indices,
202206
GError **error);
203207

204208
GARROW_AVAILABLE_IN_ALL
209+
GARROW_DEPRECATED_IN_24_0
205210
GArrowTable *
206211
garrow_feather_file_reader_read_names(GArrowFeatherFileReader *reader,
207212
const gchar **names,

c_glib/arrow-glib/table.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,12 @@ struct _GArrowFeatherWritePropertiesClass
163163
};
164164

165165
GARROW_AVAILABLE_IN_0_17
166+
GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new)
166167
GArrowFeatherWriteProperties *
167168
garrow_feather_write_properties_new(void);
168169

169170
GARROW_AVAILABLE_IN_0_17
171+
GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_file_writer_new)
170172
gboolean
171173
garrow_table_write_as_feather(GArrowTable *table,
172174
GArrowOutputStream *sink,

0 commit comments

Comments
 (0)