Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BaseSensor out of core and in to TaskSDK definitions #45743

Closed
ashb opened this issue Jan 17, 2025 · 1 comment · Fixed by #48244
Closed

Move BaseSensor out of core and in to TaskSDK definitions #45743

ashb opened this issue Jan 17, 2025 · 1 comment · Fixed by #48244
Assignees
@kaxil
Labels
affected_version:3.0.0beta For all 3.0.0 beta releases area:core-operators Operators, Sensors and hooks within Core Airflow

Comments

@ashb
Copy link
Member

ashb commented Jan 17, 2025 •
edited
Loading

airflow.sensors.base.BaseSensor needs to live in the Task SDK as airflow.sdk.definitions.sensors.BaseSensor, and all of the providers need to be adjusted to conditionally import from TaskSDK if they can.

(I'm not sure if we've done the equivalent of this second part yet for BaseOperator etc. If we haven't they we shouldn't do it for base sensor, but instead make airflow.sensors.base "re-export" the BaseSensor from the TaskSDK module for now)
@ashb ashb converted this from a draft issue Jan 17, 2025
@ashb ashb self-assigned this Jan 17, 2025
@dosubot dosubot bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Jan 17, 2025
@kaxil
Copy link
Member

kaxil commented Jan 21, 2025

Related: #45823

@ashb ashb removed their assignment Feb 24, 2025
@ashb ashb mentioned this issue Feb 24, 2025
Closed
@kaxil kaxil self-assigned this Mar 11, 2025
@kaxil kaxil moved this from Todo to Next 2 Weeks in AIP-72 - Task Execution Interface and SDK Mar 11, 2025
@kaxil kaxil moved this from Next 2 Weeks to In Progress in AIP-72 - Task Execution Interface and SDK Mar 11, 2025
@ashb ashb mentioned this issue Mar 23, 2025
Closed
2 tasks
@vatsrahul1001 vatsrahul1001 added the affected_version:3.0.0beta For all 3.0.0 beta releases label Mar 24, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
82d4f06 
closes apache#45743
@kaxil kaxil mentioned this issue Mar 25, 2025
Merged
3 tasks
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
ce6435f 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
ae31c00 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
b563756 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
9d21a3f 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 25, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
a7a4228 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 26, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
b66e03e 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 26, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
41a5dfa 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 26, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
e33ea1b 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 26, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
a1ccc5e 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 26, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
60f5d3f 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
23f5210 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
7de0e03 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
b9928ee 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
c0ba64c 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
8ecf14f 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
9be51d4 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
7cdfa3c 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 27, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
cfed275 
closes apache#45743
kaxil added a commit to astronomer/airflow that referenced this issue Mar 28, 2025
@kaxil
Move BaseSensorOperator to TaskSDK definitions
8629fa3 
closes apache#45743
@kaxil kaxil closed this as completed in 347c98c Mar 28, 2025
pankajkoti pushed a commit to astronomer/airflow that referenced this issue Mar 28, 2025
@kaxil @pankajkoti
Move BaseSensorOperator to TaskSDK definitions (apache#48244)
81618c6 
closes apache#45743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaxil kaxil

Labels
affected_version:3.0.0beta For all 3.0.0 beta releases area:core-operators Operators, Sensors and hooks within Core Airflow
Projects
AIP-72 - Task Execution Interface and SDK
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move BaseSensorOperator to TaskSDK definitions astronomer/airflow
3 participants
@ashb @kaxil @vatsrahul1001