fix: avoid access document or window in server side #4101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
X6在多处module scope中直接访问了
document
、window
等仅在client端可用的变量,导致一旦import '@antv/X6'
服务端渲染就会出错(根据README,X6本应该支持服务端渲染)X6/README.md
Line 32 in f2cae96
本PR将
document
等移至函数中,或加上条件保护,使代码在server端也能正常运行。Motivation and Context
fix #4095
Types of changes
Self Check before Merge