Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation support #2

Open
vsubhuman opened this issue May 22, 2018 · 2 comments
Open

Translation support #2

vsubhuman opened this issue May 22, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request must Obligatory feature

Comments

@vsubhuman
Copy link
Member

For now - all useful text is in full bullshit mode along with the logic code. This is horrible and impossible to translate without creating a separate page.

Extract all useful text into (instructions, parameter labels, tooltips, etc.) into separate file[s] and add some dynamic linking with a selector, so people could contribute translations and users could chose a language.

@vsubhuman vsubhuman added the enhancement New feature or request label May 22, 2018
@vsubhuman vsubhuman self-assigned this May 22, 2018
@vsubhuman vsubhuman added the must Obligatory feature label May 22, 2018
@gufmar
Copy link

gufmar commented May 28, 2018

would it be possible to consider the browser language and then use some of most common number formattings?
https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use
It would help first-time-users to prevent mistakes if they're staking 10 or 10k ADAs

@vsubhuman
Copy link
Member Author

would it be possible to consider the browser language and then use some of most common number formattings?

Oh yeah, this is actually an important feature. The formatting in the context fields (to the right of input fields) is easy, since there's just a US-locale hardcoded for now, so I can try to extract one from browser. The formatting in the input field themselves is a bit harder, since I couldn't find any native support for a preformatted number fields, so I had to use a side-library that does all the magic. I hope it is configurable enough, so I prolly could extract order- and decimal-separators for the browser's locale and then just make that library use it.

Dang, decimal separators are especially hard, since users need to input those manually, and example wiki shows that for some locales those are "unexpectedly weird" (https://i.imgur.com/mLHw7RZ.png) :)

Anyways, really nice spot, thank you for that! I will create a separate issue and will try to squeeze it into upcoming 0.1.1 (with new layout) or into 0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request must Obligatory feature
Projects
None yet
Development

No branches or pull requests

2 participants