Allowing multiple specialized bot in the same PR (using smart invisible tags) #780
+53
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Critical fix for multi-bot support. When multiple bots use the same bot ID (e.g., Claude's official bot ID 41898282), they were matching each other's comments due to the OR logic in comment matching. New logic: - If comment has a hidden header, require BOTH header AND ID to match - This prevents Bot A from matching Bot B's comment when they share an ID - Maintains backward compatibility for old comments without headers Without this fix, claude-security and claude-code-review would overwrite each other's comments.
|
related issue -- #419 |
4 tasks
|
here's my take on this -- #789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing multiple Claude Reviewers in the same PR by changing the bot_name (e.g. security_review vs science_skills)
Implementation detail
Adding an hidden Header Identification (src/github/operations/comments/common.ts)
- Adds header when useStickyComment=true
- Invisible to users, used for bot identification
Following up on the previous request #411 with a simplified approach