|
| 1 | +{ |
| 2 | + "cells": [ |
| 3 | + { |
| 4 | + "cell_type": "markdown", |
| 5 | + "metadata": {}, |
| 6 | + "source": [ |
| 7 | + "# Peer Review Guidelines\n", |
| 8 | + "\n", |
| 9 | + "When writing a peer review give the code a look over and think about the questions below. Giving a couple of sentences for each of the questions is sufficient. Code examples are even better!\n", |
| 10 | + "\n", |
| 11 | + "1. Easy to read and understand?\n", |
| 12 | + " - Are the `doc-strings` useful?\n", |
| 13 | + " - Are variables and functions named descriptively when useful?\n", |
| 14 | + " - Are the comments helpful?\n", |
| 15 | + "1. Does the code follow a consistent style?\n", |
| 16 | + " - Is there a consistent style? [PEP8](https://www.python.org/dev/peps/pep-0008/)\n", |
| 17 | + "1. Is the code written succinctly and efficiently?\n", |
| 18 | + " - Was there superfluous code sections?\n", |
| 19 | + " - Was the code written clearly?\n", |
| 20 | + " - Was the code written elegantly without decreasing readability?\n", |
| 21 | + " \n", |
| 22 | + "Make sure to suggest **constructive** ways to improve all of the above along with:\n", |
| 23 | + " - Clever ways to use built-in functionality (when appropriate)\n", |
| 24 | + " - Simpler ways to implement the same functionality\n", |
| 25 | + " - General improvements to structure, style, and naming\n", |
| 26 | + " - Be courteous to the person you are reviewing!\n", |
| 27 | + "\n", |
| 28 | + "\n", |
| 29 | + "## Rubric\n", |
| 30 | + "<table>\n", |
| 31 | + " <tr>\n", |
| 32 | + " <th>Criteria</th>\n", |
| 33 | + " <th>3 points</th>\n", |
| 34 | + " <th>2 points</th>\n", |
| 35 | + " <th>1 point</th>\n", |
| 36 | + " </tr>\n", |
| 37 | + " <tr>\n", |
| 38 | + " <td>Readability</td>\n", |
| 39 | + " <td><ul>\n", |
| 40 | + " <li>Doc-strings are clear and accurate</li>\n", |
| 41 | + " <li>Variables and functions are named descriptively when useful</li>\n", |
| 42 | + " <li>Comments are placed in appropriate places and are clear and accurate</li>\n", |
| 43 | + " </ul>\n", |
| 44 | + " </td>\n", |
| 45 | + " <td><ul>\n", |
| 46 | + " <li>Doc-strings are present but not completely descriptive</li>\n", |
| 47 | + " <li>Variables and functions are sometimes named helpfully</li>\n", |
| 48 | + " <li>Comments are present but not always accurate or in the most helpful of places</li>\n", |
| 49 | + " </ul>\n", |
| 50 | + " </td>\n", |
| 51 | + "\n", |
| 52 | + " <td><ul>\n", |
| 53 | + " <li>No doc-strings</li>\n", |
| 54 | + " <li>Variables and functions are named indecipherably</li>\n", |
| 55 | + " <li>No or inaccurate comments</li>\n", |
| 56 | + " </ul>\n", |
| 57 | + " </td>\n", |
| 58 | + " </tr>\n", |
| 59 | + " <tr>\n", |
| 60 | + " <td>Style</td>\n", |
| 61 | + " <td><ul>\n", |
| 62 | + " <li><a href=\"https://www.python.org/dev/peps/pep-0008/\">PEP 8</a> or other style is consistent</li>\n", |
| 63 | + " <li>Indentation is clean and not mixed</li>\n", |
| 64 | + " </ul>\n", |
| 65 | + " <td><ul>\n", |
| 66 | + " <li>Style is mostly consistent with something</li>\n", |
| 67 | + " </ul>\n", |
| 68 | + " </td>\n", |
| 69 | + " <td><ul>\n", |
| 70 | + " <li>Style is of a by-gone era but may come back someday (not today)</li>\n", |
| 71 | + " </ul>\n", |
| 72 | + " </td>\n", |
| 73 | + " </tr>\n", |
| 74 | + " <tr>\n", |
| 75 | + " <td>Code Awesome</td>\n", |
| 76 | + " <td><ul>\n", |
| 77 | + " <li>Code was succinct and clean</li>\n", |
| 78 | + " <li>Upon a glance you completely understood the code</li>\n", |
| 79 | + " <li>This code defines elegance</li>\n", |
| 80 | + " </td>\n", |
| 81 | + " <td><ul>\n", |
| 82 | + " <li>Code was overall clean but there were a couple spots</li>\n", |
| 83 | + " <li>Code was mostly clear except for a couple of spots</li>\n", |
| 84 | + " <li>Code worked but may have been a bit hard to follow</li>\n", |
| 85 | + " </td>\n", |
| 86 | + " <td><ul>\n", |
| 87 | + " <li>Code had large sections that did nothing</li>\n", |
| 88 | + " <li>Code was very hard to follow</li>\n", |
| 89 | + " <li>Code got the job done but no one would ever understand why</li>\n", |
| 90 | + " </ul></td>\n", |
| 91 | + " </tr>\n", |
| 92 | + "</table>\n" |
| 93 | + ] |
| 94 | + } |
| 95 | + ], |
| 96 | + "metadata": { |
| 97 | + "kernelspec": { |
| 98 | + "display_name": "Python 2", |
| 99 | + "language": "python", |
| 100 | + "name": "python2" |
| 101 | + }, |
| 102 | + "language_info": { |
| 103 | + "codemirror_mode": { |
| 104 | + "name": "ipython", |
| 105 | + "version": 3 |
| 106 | + }, |
| 107 | + "file_extension": ".py", |
| 108 | + "mimetype": "text/x-python", |
| 109 | + "name": "python", |
| 110 | + "nbconvert_exporter": "python", |
| 111 | + "pygments_lexer": "ipython3", |
| 112 | + "version": "3.6.2" |
| 113 | + }, |
| 114 | + "latex_envs": { |
| 115 | + "bibliofile": "biblio.bib", |
| 116 | + "cite_by": "apalike", |
| 117 | + "current_citInitial": 1, |
| 118 | + "eqLabelWithNumbers": true, |
| 119 | + "eqNumInitial": 0 |
| 120 | + } |
| 121 | + }, |
| 122 | + "nbformat": 4, |
| 123 | + "nbformat_minor": 1 |
| 124 | +} |
0 commit comments