Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose analysis plies under SolidModel and ImportedSolidModel #711

Open
roosre opened this issue Nov 27, 2024 · 1 comment
Open

Expose analysis plies under SolidModel and ImportedSolidModel #711

roosre opened this issue Nov 27, 2024 · 1 comment
Labels
enhancement Improvement to an existing feature needs-backend-changes Needs changes in the ACP gRPC server backend

Comments

@roosre
Copy link
Contributor

roosre commented Nov 27, 2024

📝 Description of the feature

The analysis plies of (imported) solid model are not accessible in the Python frontend. List of plies can contain in the case of a Solid Model Analysis Plies and Interface Layers, Analysis Plies and ImportedAnalysisPlies in case of an ImportedSolidModel.
Simplify examples (Imported Plies, Imported Solid Model and Solid Model) by retrieving the analysis plies directly from the solid mode instead via the original modeling ply.

💡 Steps for implementing the feature

No response

🔗 Useful links and references

No response

@roosre roosre added the enhancement Improvement to an existing feature label Nov 27, 2024
@greschd greschd assigned greschd and unassigned greschd Nov 27, 2024
@greschd
Copy link
Member

greschd commented Nov 27, 2024

This will require some backend changes:

  • for the Interface Layer and Imported Analysis Ply, exposure on the (Imported) Solid Model is not yet implemented -> added backend work item
  • for the Analysis Ply on an Imported Solid Model, I am getting the following error: Analyis-ply has no parent production-ply!. The reason for this is that filler plies don't have a correspondence in the Modeling Group hierarchy (and thus no production ply parent). This will need to be addressed in the backend. -> added backend bug
  • I think the regular Solid Model can (maybe?) also contain Imported Analysis Ply objects.

Analysis plies on SM seem to work as expected.

WIP branch: feat/plies_on_solid_models

Related: #7

greschd added a commit that referenced this issue Nov 28, 2024
Add a read-only 'analysis_plies' collection to the solid model.
This collection contains only the AnalysisPly objects, the
InterfaceLayer objects are not included.

Partially addresses #711.
greschd added a commit that referenced this issue Nov 28, 2024
Add a read-only 'analysis_plies' collection to the solid model.
This collection contains only the AnalysisPly objects, the
InterfaceLayer objects are not included.

Partially addresses #711.

Co-authored-by: René Roos <[email protected]>
@roosre roosre added this to the 2025R2 release milestone Nov 29, 2024
@greschd greschd added the needs-backend-changes Needs changes in the ACP gRPC server backend label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature needs-backend-changes Needs changes in the ACP gRPC server backend
Projects
None yet
Development

No branches or pull requests

2 participants