Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer menu style is broken when loaded from iphone home screen #57

Open
hslee33754 opened this issue Feb 27, 2022 · 3 comments
Open

Footer menu style is broken when loaded from iphone home screen #57

hslee33754 opened this issue Feb 27, 2022 · 3 comments
Assignees

Comments

@hslee33754
Copy link

image

OS: iOS 15.3.1
Browser: Safari (home screen)
Repro Steps:

  1. Open https://www.ferry.fyi on iPhone Safari
  2. Click the share icon from the url bar
  3. Click "Add to Home Screen"
  4. Open the page from the added home screen button
  5. click any location to display footer menus

Footer menu style is broken when the page is loaded from the iPhone home screen. It looks fine when it is opened on a regular safari tab or other browsers. I did a little debugging and it looks like the env(safe-area-inset-XXXXX) values break the style.

Overwriting values to 0 on margin bottom on the Footer and the padding top and bottom on the child fixes it.

It might need to use a media query of [display-mode: standalone](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/display-mode) to make the spacing values conditional.

@anstosa
Copy link
Owner

anstosa commented Feb 27, 2022

Thanks for the debugging @hslee33754 ! Super helpful since I don't have an iPhone 😊

@anstosa anstosa self-assigned this Feb 27, 2022
@hslee33754
Copy link
Author

@anstosa Thank YOU for building this app. I've been wanting to build something like this, and I am loving it!

anstosa added a commit that referenced this issue Apr 3, 2022
@anstosa
Copy link
Owner

anstosa commented Apr 3, 2022

Just pushed a potential fix based on your comment. Can't test so let me know if it works!

You may have to close the app from your recents and re-open it once or twice for the service worker to pick up the changes

@anstosa anstosa added this to Board Jul 28, 2024
@anstosa anstosa moved this to In Progress in Board Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants