Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'var-naming warns on variables with dynamically set names' removed #4296

Closed
erichiller opened this issue Aug 21, 2024 · 1 comment · Fixed by #4372
Closed

Fix for 'var-naming warns on variables with dynamically set names' removed #4296

erichiller opened this issue Aug 21, 2024 · 1 comment · Fixed by #4372
Assignees
Labels

Comments

@erichiller
Copy link

The same issue as reported in #1680 (var-naming warns on variables with dynamically set names) and fixed in #1988 (See file diff) was then later undone in #3422 , but that commit does not appear to have been about var-naming[no-jinja]. In fact the comment from the original fix is still present,

        # We want to allow use of jinja2 templating for variable names
        if "{{" in ident:

so I can only assume that the removal of the return False was not intentional.

Can the behaviour post #1988 be restored?

@erichiller erichiller added bug new Triage required labels Aug 21, 2024
@shatakshiiii
Copy link
Contributor

@ssbarnea ^^

@alisonlhart alisonlhart removed the new Triage required label Oct 23, 2024
ssbarnea added a commit that referenced this issue Oct 23, 2024
ssbarnea added a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants