This repository was archived by the owner on Mar 23, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 388
Deployment artifacts proposal #850
Open
chouseknecht
wants to merge
1
commit into
ansible:develop
Choose a base branch
from
chouseknecht:feature/deployment-artifact-proposal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Refactor Deployment Artifacts | ||
|
|
||
| ## Summary | ||
|
|
||
| Produce a portable, better organized deployment artifact that uses an Ansible role, and the new Ansible 2.5 K8s modules. | ||
|
|
||
| ## Details | ||
|
|
||
| Deployment currently generates the following artifacts: | ||
|
|
||
| - Single, monolithic playbook containing all tasks, and all K8s object configurations inline | ||
| - Copy of the `ansible.kubernetes-modules` role | ||
|
|
||
| This proposal is to replace the current artifacts with the following: | ||
|
|
||
| - Playbook that executes a role | ||
| - Role containing K8s object configuration files separate from playbook tasks | ||
|
|
||
| The generated role will include the following: | ||
|
|
||
| - Task files that group tasks by function (e.g., start, stop, destroy, etc.) | ||
| - A separate configuration file for each K8s object | ||
| - README.md file for the role, providing how-to information, and contents descriptions | ||
|
|
||
| Additional details include: | ||
|
|
||
| - The playbook name and role name will match the project name | ||
| - Tasks will be tagged, so that the playbook can be used to perform an action based on tag, as it does today | ||
| - New modules available in Ansible 2.5 will be used, rather than the `ansible.kubernetes-modules` role. | ||
|
|
||
| Artifacts will be written to the following directory structure: | ||
|
|
||
| ``` | ||
| ansible-deployment/ | ||
| project-name.yml | ||
| project-name/ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was my thinking for the role. It would just be written out in it's own directory, rather than placing it under a
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh right, makes perfect sense now; feel free to leave it as it is |
||
| README.md | ||
| config/ | ||
| deployments/ | ||
| routes/ | ||
| services/ | ||
| pvcs/ | ||
| secrets/ | ||
| ... | ||
| tasks/ | ||
| main.yml | ||
| start.yml | ||
| stop.yml | ||
| destroy.yml | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where will the role(s) be placed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasTomecek
Was thinking we would continue writing artifacts into the
ansible-deploymentsubdirectory thatdeployadds to the project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just curious where would the generated role(s) be placed. You wrote that
When I look at the proposed directory hierarchy, I'm not sure which directory will have the resulting, generated role(s).
Also, what will be the default action of the root playbook
project-name.yml?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking the playbook is really simple. Maybe something like the following: