zypper_repository: extend module with possibility to modify repos #8795
Conversation
ansibullbot
added
feature
computersalat
force-pushed
the
zypper_repository
branch
3 times, most recently
from
bdf0dd3
to
3931bf5
Compare
felixfontein
added
check-before-release
ansibullbot
added
the
needs_revision
| type: str | ||
| state: | ||
| action: |
There was a problem hiding this comment.
Please note that module options such as action are not a good idea (https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#designing-module-interfaces), in particular if state is already present.
All your actions should already be doable with state. Modifying should be done with state=present and passing other parameters.
There was a problem hiding this comment.
I hear you, but state with [ "absent", "present" ] is only relevant when using add or remove, but it's irrelevant when using action with [ "modify" ]. When I modify a repo I expect it to be present.
Introducing action was IMHO the only possibility to add feature: modify.
If you have a better idea, I am open to hear ...
There was a problem hiding this comment.
No, state=present usually also means modify (except in certain situations, like it hasn't been implemented yet).
Please remove the action option and change the code so that with state=present it creates (if it doesn't exist yet) or modifies (if it does exist and is changed).
computersalat
force-pushed
the
zypper_repository
branch
from
3931bf5
to
5171eed
Compare
computersalat
force-pushed
the
zypper_repository
branch
from
5171eed
to
1c7dae1
Compare
SUMMARY
Extend module to also modify (zypper mr) repos.
ISSUE TYPE
COMPONENT NAME
zypper_repository
ADDITIONAL INFORMATION
I missed the possibility to modify (zypper mr) existing repositories like
enableordisable. I didn't like theaddandremoveonly approach because I created the repo files via templates with my own naming scheme.Especially when you want to do a zypper dup you need to add the new repos
enabledwhiledisablingcurrent repos.This extension gives the user more possibilies to use this module.