Skip to content

[Review] SSRF via ATLASCOIN_URL environment variable #91

@github-actions

Description

@github-actions

Review Finding

PR: #75 (feat: MCP server source control + 5 new session tools)
File: src/atlas_session/contract/atlascoin.py
Line: 13
Severity: must-fix

Description

ATLASCOIN_URL is read directly from the environment and used without validation as the base for all HTTP requests, including those that send soul_purpose, evidence, and escrow amounts. An attacker who can set environment variables can redirect these to an arbitrary server. Validate the URL scheme and host at startup (allow only http://localhost:* or require an explicit allowlist), and reject requests if the URL is not well-formed.


Auto-created by Claude Code Review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    review-blockingBlocks PR merge until resolved

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions