Skip to content

feat(core): add indexed color (0-255) and OSC palette control #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bresilla wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(core): add indexed color (0-255) and OSC palette control #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e16f69f
feat(core): add indexed color (0-255) support
bresilla Jan 20, 2026
d907260
fix(core): wire indexed/default colors through FFI; validate OSC hex;…
bresilla Jan 20, 2026
222ab4b
fix(core): preserve indexed colors across render paths
bresilla Jan 21, 2026
0eeea68
fix(core): sanitize color metadata for FFI
bresilla Jan 21, 2026
931a7c1
Merge branch 'main' into feat/indexed-colors
bresilla Jan 22, 2026
b4e296f
Merge branch 'main' into feat/indexed-colors
kommander Jan 23, 2026
522bd9d
Merge remote-tracking branch 'upstream/main' into feat/indexed-colors
bresilla Jan 23, 2026
e4782f8
refactor(core): keep parseColor stateless
bresilla Jan 23, 2026
5472d9f
Merge remote-tracking branch 'origin/feat/indexed-colors' into feat/i…
bresilla Jan 23, 2026
c23bfc4
fix(core): normalize syntax style colors
bresilla Jan 24, 2026
c3322fa
Merge branch 'main' into feat/indexed-colors
bresilla Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions packages/core/src/buffer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,23 @@ export class OptimizedBuffer {

public clear(bg: RGBA = RGBA.fromValues(0, 0, 0, 1)): void {
this.guard()
this.lib.bufferClear(this.bufferPtr, bg)
const hasColorTypeInfo = bg.colorType !== undefined
if (hasColorTypeInfo) {
this.lib.bufferClearWithColorType(this.bufferPtr, bg)
} else {
this.lib.bufferClear(this.bufferPtr, bg)
}
}

public setCell(x: number, y: number, char: string, fg: RGBA, bg: RGBA, attributes: number = 0): void {
this.guard()
this.lib.bufferSetCell(this.bufferPtr, x, y, char, fg, bg, attributes)
// Check if either color has color type info (indexed or default)
const hasColorTypeInfo = fg.colorType !== undefined || bg.colorType !== undefined
if (hasColorTypeInfo) {
this.lib.bufferSetCellWithColorType(this.bufferPtr, x, y, char, fg, bg, attributes)
} else {
this.lib.bufferSetCell(this.bufferPtr, x, y, char, fg, bg, attributes)
}
}

public setCellWithAlphaBlending(
Expand All @@ -172,7 +183,13 @@ export class OptimizedBuffer {
attributes: number = 0,
): void {
this.guard()
this.lib.bufferSetCellWithAlphaBlending(this.bufferPtr, x, y, char, fg, bg, attributes)
// Check if either color has color type info (indexed or default)
const hasColorTypeInfo = fg.colorType !== undefined || bg.colorType !== undefined
if (hasColorTypeInfo) {
this.lib.bufferSetCellWithAlphaBlendingAndColorType(this.bufferPtr, x, y, char, fg, bg, attributes)
} else {
this.lib.bufferSetCellWithAlphaBlending(this.bufferPtr, x, y, char, fg, bg, attributes)
}
}

public drawText(
Expand Down
Loading