Skip to content

Commit 342d8f1

Browse files
committed
chore(ci): gate a stable release on the linux browser suites
the windows playwright legs still fail on dev pushes often enough that a release gate over them would stall shipping. unit tests and builds still cover both OSes, and dev pushes and nightly runs still cover the windows browser legs.
1 parent a873336 commit 342d8f1

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

‎.github/workflows/check-test.yml‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
name: check-test
22

33
# Pull requests run the fast tier: the affected unit tests on Linux. The full tier — unit tests on Windows, the
4-
# compiled builds, and the Playwright suites on both OSes — runs on pushes to dev and beta, on nightly and manual
5-
# runs, and as the gate release.yml calls before it publishes a stable release.
4+
# compiled builds, and the Playwright suites on both OSes — runs on pushes to dev and beta and on nightly and manual
5+
# runs. A stable release also runs it through release.yml's gate, with the browser suites on Linux only.
66
on:
77
push:
88
branches:
@@ -22,6 +22,10 @@ on:
2222
description: Run only the quarantined browser tests (packages/app/e2e/QUARANTINE.md)
2323
type: boolean
2424
default: false
25+
release_gate:
26+
description: Run the browser suites on Linux only
27+
type: boolean
28+
default: false
2529

2630
concurrency:
2731
# A new push to a pull request cancels its stale run. Every push and manual run keeps its own group, so each
@@ -224,12 +228,9 @@ jobs:
224228
strategy:
225229
fail-fast: false
226230
matrix:
227-
# Browser suites only run on pushes, nightly runs and the release gate, so every run covers both OSes.
228-
settings:
229-
- name: linux
230-
host: blacksmith-4vcpu-ubuntu-2404
231-
- name: windows
232-
host: blacksmith-4vcpu-windows-2025
231+
# The release gate runs the Linux browser suites only: the Windows legs still fail on dev pushes often
232+
# enough that a stable release must not wait for them. Pushes and nightly runs cover Windows.
233+
settings: ${{ fromJSON(inputs.release_gate && '[{"name":"linux","host":"blacksmith-4vcpu-ubuntu-2404"}]' || '[{"name":"linux","host":"blacksmith-4vcpu-ubuntu-2404"},{"name":"windows","host":"blacksmith-4vcpu-windows-2025"}]') }}
233234
quarantine: ${{ fromJSON(inputs.quarantine && '[true]' || '[false]') }}
234235
# Playwright splits whole spec files across shards by test count, not duration. Every app-N
235236
# entry must use the same total, and the entries must cover 1..total. The service worker suite

‎.github/workflows/release.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ jobs:
8282
# ---- Gate: the full check suite, before anything is published ------------------------------------------------
8383

8484
# release.yml does not wait for the check-test push run on the same commit, so a stable release would publish
85-
# whatever that run later says. This gate runs the whole suite — unit tests on both OSes, the compiled builds
86-
# and the browser suites — before any publish job below. Continuous dev and beta builds skip it: they publish
85+
# whatever that run later says. This gate runs the whole suite — unit tests on both OSes, the compiled builds and
86+
# the Linux browser suites — before any publish job below. Continuous dev and beta builds skip it: they publish
8787
# their own channel from a dev push, whose check-test run covers the same commit.
8888
verify:
8989
needs: plan
@@ -92,6 +92,8 @@ jobs:
9292
contents: read
9393
checks: write
9494
uses: ./.github/workflows/check-test.yml
95+
with:
96+
release_gate: true
9597

9698
# A versioned release builds from a commit with its versions and changelog on the dispatched dev commit,
9799
# tagged v<version>. Runs git only.

0 commit comments

Comments
 (0)