fix: update eslint configuration and dependencies

prisis · prisis · commit 207d52e6f9c9 · 2025-09-05T23:12:28.000+02:00
- Disabled unocss in eslint.config.js and added additional ignores for specific files.
- Updated package.json to include new dependency versions for eslint-plugin-playwright and tailwind-csstree.
- Refactored eslint configuration files to improve rule management and added new rules for TypeScript and CSS processing.
- Enhanced interop-default utility to handle default exports more robustly.
- Improved handling of environment variables in is-in-git-hooks-or-lint-staged utility.
diff --git a/eslint.config.js b/eslint.config.js
@@ -2,8 +2,11 @@ import { createConfig } from "./packages/eslint-config/dist/index.mjs";
 
 export default createConfig({
     zod: true,
-    unocss: true,
+    unocss: false,
     ignores: [
-        "eslint.config.js"
+        "eslint.config.js",
+        "packages/eslint-config/__fixtures__/**",
+        "packages/eslint-config/README.md",
+        "packages/eslint-config/src/vender/**"
     ]
 });
diff --git a/package.json b/package.json
@@ -144,24 +144,24 @@
         "overrides": {
             "@babel/helpers@<7.26.10": ">=7.27.6",
             "@babel/runtime@<7.26.10": ">=7.27.6",
+            "@eslint/plugin-kit@<0.3.3": ">=0.3.3",
             "@octokit/endpoint@>=10.0.0 <10.1.3": ">=10.1.4",
             "@octokit/plugin-paginate-rest@>=9.3.0-beta.1 <11.4.1": ">=11.6.0",
             "@octokit/request@>=9.0.0-beta.1 <9.2.1": ">=9.2.4",
             "@octokit/request-error@>=6.0.0 <6.1.7": ">=6.1.8",
             "chrono-node@<2.2.4": ">=2.8.3",
             "cross-spawn@>=7.0.0 <7.0.5": ">=7.0.6",
             "esbuild@<=0.24.2": ">=0.25.6",
+            "form-data@>=4.0.0 <4.0.4": ">=4.0.4",
             "nanoid@<3.3.8": ">=3.3.11",
+            "tmp@<=0.2.3": ">=0.2.4",
             "vite@>=5.0.0 <=5.4.18": ">=5.4.19",
             "vite@>=5.0.0 <=5.4.11": ">=5.4.12",
             "vite@>=5.0.0 <5.4.18": ">=5.4.18",
             "vite@>=5.0.0 <5.4.17": ">=5.4.17",
             "vite@>=5.0.0 <5.4.16": ">=5.4.16",
             "vite@>=5.0.0 <5.4.15": ">=5.4.15",
-            "vitest@>=2.0.0 <2.1.9": ">=2.1.9",
-            "@eslint/plugin-kit@<0.3.3": ">=0.3.3",
-            "form-data@>=4.0.0 <4.0.4": ">=4.0.4",
-            "tmp@<=0.2.3": ">=0.2.4"
+            "vitest@>=2.0.0 <2.1.9": ">=2.1.9"
         }
     }
 }
diff --git a/packages/eslint-config/eslint.config.js b/packages/eslint-config/eslint.config.js
@@ -26,6 +26,24 @@ export default createConfig(
         files: ["**/*.ts"],
         rules: {
             "no-secrets/no-secrets": "off",
+            "@typescript-eslint/require-await": "off",
+            "@typescript-eslint/no-unsafe-assignment": "off",
+            "@typescript-eslint/no-unsafe-argument": "off",
+            "@typescript-eslint/restrict-template-expressions": "off",
+        },
+    },
+    {
+        files: ["__fixtures__/**"],
+        rules: {
+            "@unocss/order-attributify": "off",
+            "@unocss/order": "off",
+        },
+    },
+    {
+        files: ["**/*"],
+        rules: {
+            "@unocss/order-attributify": "off",
+            "@unocss/order": "off",
         },
     },
     {
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -212,6 +212,8 @@
         "react": "^19.1.1",
         "rimraf": "^6.0.1",
         "semantic-release": "^24.2.7",
+        "eslint-plugin-playwright": "2.2.2",
+        "tailwind-csstree": "0.1.4",
         "tinyglobby": "^0.2.14",
         "tsx": "^4.20.5",
         "type-fest": "^4.41.0",
@@ -242,7 +244,8 @@
         "eslint-plugin-tsdoc": "^0.4.0",
         "eslint-plugin-validate-jsx-nesting": "^0.1.1",
         "eslint-plugin-you-dont-need-lodash-underscore": "^6.14.0",
-        "eslint-plugin-zod": "^1.4.0"
+        "eslint-plugin-zod": "^1.4.0",
+        "tailwind-csstree": "0.1.4"
     },
     "peerDependenciesMeta": {
         "@eslint-react/eslint-plugin": {
@@ -317,6 +320,9 @@
         "eslint-plugin-zod": {
             "optional": true
         },
+        "tailwind-csstree": {
+            "optional": true
+        },
         "typescript": {
             "optional": true
         }
diff --git a/packages/eslint-config/scripts/global-vitest.ts b/packages/eslint-config/scripts/global-vitest.ts
@@ -34,14 +34,15 @@ const extract = (file: string) => {
         if (ts.isModuleDeclaration(node)) {
             ts.forEachChild(node.body as ModuleBody, (mNode) => {
                 if (ts.isVariableStatement(mNode)) {
-                    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                    ts.forEachChild(mNode, (vNode: any) => {
+                    ts.forEachChild(mNode, (vNode) => {
                         if (ts.isVariableDeclarationList(vNode)) {
                             for (const declaration of vNode.declarations) {
                                 const name = ts.getNameOfDeclaration(declaration);
 
-                                if (name && "escapedText" in name) {
-                                    globals.push(name.escapedText as string);
+                                const escaped = (name as unknown as { escapedText?: unknown }).escapedText;
+
+                                if (typeof escaped === "string") {
+                                    globals.push(escaped);
                                 }
                             }
                         }
diff --git a/packages/eslint-config/src/config/plugins/css.ts b/packages/eslint-config/src/config/plugins/css.ts
@@ -6,7 +6,11 @@ export default createConfig<OptionsFiles & OptionsOverrides & { tailwind?: boole
     const { files = oFiles, overrides, tailwind } = config;
 
     const cssPlugin = await interopDefault(import("@eslint/css"));
-    const cssSyntax = await interopDefault(import("@eslint/css/syntax"));
+    let tailwindCustomSyntax;
+
+    if (tailwind) {
+        tailwindCustomSyntax = await interopDefault(import("tailwind-csstree"));
+    }
 
     return [{
         files,
@@ -16,21 +20,24 @@ export default createConfig<OptionsFiles & OptionsOverrides & { tailwind?: boole
             css: cssPlugin,
         },
         rules: {
+            "@stylistic/indent": "off",
             "css/no-duplicate-imports": "error",
             "css/no-empty-blocks": "error",
             "css/no-important": "error",
             "css/no-invalid-at-rules": "error",
             "css/no-invalid-properties": "error",
             "css/use-baseline": "warn",
             "css/use-layers": "error",
+            // Disable JS-core rule for CSS language to avoid parser mismatch errors
+            "no-irregular-whitespace": "off",
 
             ...overrides,
         },
 
-        ...tailwind
+        ...tailwind && tailwindCustomSyntax
             ? {
                 languageOptions: {
-                    customSyntax: cssSyntax.tailwindSyntax,
+                    customSyntax: tailwindCustomSyntax.tailwind4,
                     tolerant: true,
                 },
             }
diff --git a/packages/eslint-config/src/config/plugins/formatters.ts b/packages/eslint-config/src/config/plugins/formatters.ts
@@ -9,7 +9,7 @@ const mergePrettierOptions = (options: VendoredPrettierOptions, overrides: Vendo
     return {
         ...options,
         ...overrides,
-        plugins: [...overrides.plugins || [], ...options.plugins || []],
+        plugins: [...overrides.plugins ?? [], ...options.plugins ?? []],
     };
 };
 
@@ -34,7 +34,7 @@ const formatters = async (options: OptionsFormatters, stylistic: StylisticConfig
             trailingComma: "all",
             useTabs: indent === "tab",
         } satisfies VendoredPrettierOptions,
-        options.prettierOptions || {},
+        options.prettierOptions ?? {},
     );
 
     const prettierXmlOptions: VendoredPrettierOptions = {
diff --git a/packages/eslint-config/src/config/plugins/markdown.ts b/packages/eslint-config/src/config/plugins/markdown.ts
@@ -29,7 +29,7 @@ export default createConfig<OptionsComponentExtensions & OptionsFiles & OptionsO
             // `eslint-plugin-markdown` only creates virtual files for code blocks,
             // but not the markdown file itself. We use `eslint-merge-processors` to
             // add a pass-through processor for the markdown file itself.
-            processor: mergeProcessors([markdown.processors?.markdown, processorPassThrough]),
+            processor: mergeProcessors([markdown.processors.markdown, processorPassThrough]),
         },
         {
             files,
@@ -53,13 +53,16 @@ export default createConfig<OptionsComponentExtensions & OptionsFiles & OptionsO
                 "@stylistic/comma-dangle": "off",
                 "@stylistic/eol-last": "off",
                 "@stylistic/prefer-global/process": "off",
+                "@stylistic/quote-props": "off",
+                "@stylistic/semi": "off",
+
+                "@typescript-eslint/no-unused-expressions": "off",
 
                 "antfu/no-top-level-await": "off",
 
                 "import/newline-after-import": "off",
 
                 "no-alert": "off",
-
                 "no-console": "off",
                 "no-labels": "off",
                 "no-lone-blocks": "off",
diff --git a/packages/eslint-config/src/config/plugins/node.ts b/packages/eslint-config/src/config/plugins/node.ts
@@ -8,7 +8,7 @@ export default createConfig<OptionsFiles & OptionsOverrides & OptionsPackageJson
 
     const pluginNode = await interopDefault(import("eslint-plugin-n"));
 
-    const nodeVersion = packageJson?.engines?.["node"];
+    const nodeVersion = packageJson.engines?.["node"];
 
     return [
         {
diff --git a/packages/eslint-config/src/config/plugins/promise.ts b/packages/eslint-config/src/config/plugins/promise.ts
@@ -1,13 +1,14 @@
 import { fixupPluginRules } from "@eslint/compat";
 
-import type { OptionsFiles, OptionsOverrides } from "../../types";
+import type { OptionsFiles, OptionsOverrides, Rules } from "../../types";
 import { createConfig } from "../../utils/create-config";
 import interopDefault from "../../utils/interop-default";
 
 // @see https://github.com/xjamundx/eslint-plugin-promise#readme
 export default createConfig<OptionsFiles & OptionsOverrides>("all", async (config, oFiles) => {
     const { files = oFiles, overrides } = config;
 
+    // @ts-expect-error missing types
     const promisesPlugin = await interopDefault(import("eslint-plugin-promise"));
 
     return [
@@ -18,7 +19,8 @@ export default createConfig<OptionsFiles & OptionsOverrides>("all", async (confi
                 promise: promisesPlugin,
             },
             rules: {
-                ...fixupPluginRules(promisesPlugin.configs["flat/recommended"].rules),
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+                ...fixupPluginRules(promisesPlugin.configs["flat/recommended"].rules) as Rules,
 
                 "promise/prefer-await-to-callbacks": "off",
                 "promise/prefer-await-to-then": "off",
diff --git a/packages/eslint-config/src/config/plugins/typescript.ts b/packages/eslint-config/src/config/plugins/typescript.ts
@@ -1,3 +1,6 @@
+import { dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+
 import type { Linter } from "eslint";
 
 import type {
@@ -53,19 +56,21 @@ export default createConfig<
     isTypeAware = isTypeAware && tsconfigPath !== undefined;
 
     const makeParser = (typeAware: boolean, pFiles: string[], ignores?: string[]): TypedFlatConfigItem => {
+        const thisDirectory = dirname(fileURLToPath(import.meta.url));
+
         return {
             files: [...pFiles, ...componentExtensions.map((extension) => `**/*.${extension}`)],
             ...ignores ? { ignores } : {},
             languageOptions: {
                 parser: tseslint.parser,
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+
                 parserOptions: {
                     extraFileExtensions: componentExtensions.map((extension) => `.${extension}`),
                     sourceType: "module",
                     ...typeAware
                         ? {
                             projectService: true,
-                            tsconfigRootDir: import.meta.dirname,
+                            tsconfigRootDir: thisDirectory,
                         }
                         : {},
                     // eslint-disable-next-line @typescript-eslint/no-explicit-any
diff --git a/packages/eslint-config/src/config/plugins/vitest.ts b/packages/eslint-config/src/config/plugins/vitest.ts
@@ -30,12 +30,12 @@ export default createConfig<OptionsFiles & OptionsHasPrettier & OptionsIsInEdito
             interopDefault(import("eslint-plugin-no-only-tests")),
         ] as const);
 
-        pluginTest = pluginTest || {
+        pluginTest = pluginTest ?? {
             ...vitestPlugin,
             rules: {
                 ...vitestPlugin.rules,
                 // extend `test/no-only-tests` rule
-                ...noOnlyTestsPlugin.rules,
+                ...noOnlyTestsPlugin?.rules,
             },
         };
 
diff --git a/packages/eslint-config/src/utils/create-config.ts b/packages/eslint-config/src/utils/create-config.ts
@@ -101,7 +101,6 @@ export const getFilesGlobs = (fileType: FileType): string[] => {
             return ["**/*.yaml", "**/*.yml"];
         }
         default: {
-            // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
             throw new Error(`Unknown file type: ${fileType}`);
         }
     }
diff --git a/packages/eslint-config/src/utils/interop-default.ts b/packages/eslint-config/src/utils/interop-default.ts
@@ -4,7 +4,7 @@ const interopDefault = async <T>(m: Awaitable<T>): Promise<T extends { default:
     const resolved = await m;
 
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    return (resolved as any).default || resolved;
+    return (resolved as any).default ?? resolved;
 };
 
 export default interopDefault;
diff --git a/packages/eslint-config/src/utils/is-in-git-hooks-or-lint-staged.ts b/packages/eslint-config/src/utils/is-in-git-hooks-or-lint-staged.ts
@@ -1,3 +1,5 @@
-const isInGitHooksOrLintStaged = (): boolean => !!(process.env["GIT_PARAMS"] || process.env["VSCODE_GIT_COMMAND"] || process.env["npm_lifecycle_script"]?.startsWith("lint-staged"));
+const isInGitHooksOrLintStaged = (): boolean => Boolean(
+    process.env["GIT_PARAMS"] ?? process.env["VSCODE_GIT_COMMAND"] ?? (process.env["npm_lifecycle_script"]?.startsWith("lint-staged") ?? false),
+);
 
 export default isInGitHooksOrLintStaged;

Original file line number	Diff line number	Diff line change
`@@ -34,14 +34,15 @@ const extract = (file: string) => {`
`34`	`34`	`if (ts.isModuleDeclaration(node)) {`
`35`	`35`	`ts.forEachChild(node.body as ModuleBody, (mNode) => {`
`36`	`36`	`if (ts.isVariableStatement(mNode)) {`
`37`		`- // eslint-disable-next-line @typescript-eslint/no-explicit-any`
`38`		`- ts.forEachChild(mNode, (vNode: any) => {`
	`37`	`+ ts.forEachChild(mNode, (vNode) => {`
`39`	`38`	`if (ts.isVariableDeclarationList(vNode)) {`
`40`	`39`	`for (const declaration of vNode.declarations) {`
`41`	`40`	`const name = ts.getNameOfDeclaration(declaration);`
`42`	`41`
`43`		`- if (name && "escapedText" in name) {`
`44`		`- globals.push(name.escapedText as string);`
	`42`	`+ const escaped = (name as unknown as { escapedText?: unknown }).escapedText;`
	`43`	`+`
	`44`	`+ if (typeof escaped === "string") {`
	`45`	`+ globals.push(escaped);`
`45`	`46`	`}`
`46`	`47`	`}`
`47`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export default createConfig<OptionsFiles & OptionsOverrides & OptionsPackageJson`
`8`	`8`
`9`	`9`	`const pluginNode = await interopDefault(import("eslint-plugin-n"));`
`10`	`10`
`11`		`- const nodeVersion = packageJson?.engines?.["node"];`
	`11`	`+ const nodeVersion = packageJson.engines?.["node"];`
`12`	`12`
`13`	`13`	`return [`
`14`	`14`	`{`