Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add social logins #137

Open
3 tasks
techno-disaster opened this issue Aug 26, 2020 · 33 comments · May be fixed by #150
Open
3 tasks

Add social logins #137

techno-disaster opened this issue Aug 26, 2020 · 33 comments · May be fixed by #150
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@techno-disaster
Copy link
Contributor

Description

As a user I would like to be able to login/sign-up using a social account, so I don't need to create a profile from scratch

Acceptance Criteria

Update [Required]

  • add google and apple sign in

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.
@techno-disaster techno-disaster added Type: Enhancement New feature or request. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Aug 26, 2020
@techno-disaster
Copy link
Contributor Author

Status on hold untill merged with backend.

@techno-disaster techno-disaster added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Aug 26, 2020
@techno-disaster techno-disaster changed the title Add socail logins Add social logins Aug 27, 2020
@shivanigupta19
Copy link

Please assign me this issue

@techno-disaster
Copy link
Contributor Author

@shivanigupta19 sure, if you want to start working on this please merge Yugantars social logins pr found here . You can ask doubts here, incase you are stuck.

@techno-disaster techno-disaster removed the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Aug 28, 2020
@shivanigupta19 shivanigupta19 removed their assignment Aug 29, 2020
@shivanigupta19
Copy link

@shivanigupta19 sure, if you want to start working on this please merge Yugantars social logins pr found here . You can ask doubts here, incase you are stuck.

Sorry by mistake i unassigned , please assign me again

@shivanigupta19
Copy link

shivanigupta19 commented Aug 30, 2020

@shivanigupta19 sure, if you want to start working on this please merge Yugantars social logins pr found here . You can ask doubts here, incase you are stuck.

Sir , i have windows so , i cannot implement apple sign in the project.
you are not using firebase in this project

@techno-disaster
Copy link
Contributor Author

@shivanigupta19 sure, if you want to start working on this please merge Yugantars social logins pr found here . You can ask doubts here, incase you are stuck.

Sir , i have windows so , i cannot implement apple sign in the project.
you are not using firebase in this project

I personally have only used google sign in up untill today, @yugantarjain can you confirm if implementing apple sign in requires a mac? IMO it shoudn't
@shivanigupta19 can you implement google sign in till then?

@shivanigupta19
Copy link

@shivanigupta19 sure, if you want to start working on this please merge Yugantars social logins pr found here . You can ask doubts here, incase you are stuck.

Sir , i have windows so , i cannot implement apple sign in the project.
you are not using firebase in this project

I personally have only used google sign in up untill today, @yugantarjain can you confirm if implementing apple sign in requires a mac? IMO it shoudn't
@shivanigupta19 can you implement google sign in till then?

Sure but in back-end what are you using ?

@techno-disaster
Copy link
Contributor Author

@yashasvimisra2798 We have a flask backend setup. Social logins are not merged yet so you will have to use this branch.

@shivanigupta19
Copy link

@techno-disaster please provide me google account with password to proceed this task.

@techno-disaster
Copy link
Contributor Author

@techno-disaster please provide me google account with password to proceed this task.

any google account should work ig?

@shivanigupta19
Copy link

@techno-disaster please provide me google account with password to proceed this task.

any google account should work ig?

@techno-disaster it will better if i use project's google account so that if there is any email regarding project or any changes , ll be easy to communicate but if i use my one , so it will create issues in future so , i cannot use my personal email. so , please make account if there is not.

@techno-disaster
Copy link
Contributor Author

@techno-disaster please provide me google account with password to proceed this task.

any google account should work ig?

@techno-disaster it will better if i use project's google account so that if there is any email regarding project or any changes , ll be easy to communicate but if i use my one , so it will create issues in future so , i cannot use my personal email. so , please make account if there is not.

There's no such project mail id as of now, please use any google account or create one. We will be communicating updates only here or on zulip.

@shivanigupta19
Copy link

@techno-disaster please provide me google account with password to proceed this task.

any google account should work ig?

@techno-disaster it will better if i use project's google account so that if there is any email regarding project or any changes , ll be easy to communicate but if i use my one , so it will create issues in future so , i cannot use my personal email. so , please make account if there is not.

There's no such project mail id as of now, please use any google account or create one. We will be communicating updates only here or on zulip.

sure , i ll make a new one.

@shivanigupta19
Copy link

@techno-disaster please provide me Application Homepage link , Application Privacy Policy link , Authorized domains

@techno-disaster
Copy link
Contributor Author

@techno-disaster please provide me Application Homepage link , Application Privacy Policy link , Authorized domains

Not sure why you might need these or what these are, but i guess you mean these?
https://mentorship-backend-temp.herokuapp.com/
We don't have a privacy policy link or auth domains afaik.
Could you tell me why / where this is needed?

@shivanigupta19
Copy link

@techno-disaster need to fill this.
WhatsApp Image 2020-09-02 at 3 35 54 PM

@techno-disaster
Copy link
Contributor Author

techno-disaster commented Sep 2, 2020

@techno-disaster need to fill this.
WhatsApp Image 2020-09-02 at 3 35 54 PM

Never seen this before, could you tell me what this is and share the link?. But if the fields are not mandatory ignore them for now

@techno-disaster
Copy link
Contributor Author

Hey, @shivanigupta19 any updates on this issue?

@techno-disaster
Copy link
Contributor Author

Unassigning @shivanigupta19 because of no updates. Feel free to ping me i case you want to be assigned again

@techno-disaster techno-disaster added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 15, 2020
@techno-disaster
Copy link
Contributor Author

@anitab-org/coding-team Anyone want to pick this up?

@NarimaneHennouni
Copy link

Hi, can I be assigned to this?

@techno-disaster
Copy link
Contributor Author

@NarimaneHennouni sure you can start working on it right away

@NarimaneHennouni
Copy link

@techno-disaster okay thank you

@Akanksha1212 Akanksha1212 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 24, 2020
@NarimaneHennouni
Copy link

NarimaneHennouni commented Sep 26, 2020

@techno-disaster Hi, I was wondering if I am allowed to use Firebase for Google and Apple sign in?

@techno-disaster
Copy link
Contributor Author

@techno-disaster Hi, I was wondering if I am allowed to use Firebase for Google and Apple sign in?

No, we already have a backend PR up. If you merge that and host the baco locally you should see the social media sign in endpoints

@NarimaneHennouni
Copy link

@techno-disaster Hi, I was wondering if I am allowed to use Firebase for Google and Apple sign in?

No, we already have a backend PR up. If you merge that and host the baco locally you should see the social media sign in endpoints

So I only need to work on the UI?

@techno-disaster
Copy link
Contributor Author

@naman1901 No, host the mentorship backend locally, merge the social logins branch linked above and integrate the google and apple login in the flutter app

@techno-disaster
Copy link
Contributor Author

@NarimaneHennouni any updates on this issue?

@techno-disaster
Copy link
Contributor Author

Unassigning due to no response. Please feel free to be assigned to this issue once again if you start working on it or are stuck somewhere.

@PaRaDoX50
Copy link

@techno-disaster Can you please assign this to me?

@techno-disaster
Copy link
Contributor Author

@techno-disaster Can you please assign this to me?

Sure.

@PaRaDoX50
Copy link

@techno-disaster Will I need to merge the Yugantar's social-sign-in branch with the current develop branch and use it as a backend locally or can I just directly use Yugantar's social-sign-in branch ? In the first case, there are a lot of conflicts which I will have to resolve.

@techno-disaster
Copy link
Contributor Author

@techno-disaster Will I need to merge the Yugantar's social-sign-in branch with the current develop branch and use it as a backend locally or can I just directly use Yugantar's social-sign-in branch ? In the first case, there are a lot of conflicts which I will have to resolve.

If you can, it would be better to merges Yugantar's branch locally with the current develop to get the backend up to date.

@PaRaDoX50 PaRaDoX50 linked a pull request Jan 12, 2021 that will close this issue
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants