-
Notifications
You must be signed in to change notification settings - Fork 767
Responsive API is not working with fxFlexFill #501
Comments
fxFlexFill is currently only a static API; see here. |
@ThomasBurleson Do you want to add a responsive API to this directive? If not, it should be closed since the docs have been updated to include this clarification. |
It would be a great addition.. right now we cant to have fxFlexFill only if fxLayout="column" and not fxLayout.gt-sm="row".. adding responsive features to fxFlexFill would make that super simple :) |
@mackelito This is probably something we could get in after beta.14 is validated, but if you wanted to throw together a PR sooner than that, I'd be happy to review it! 😄 |
@CaerusKaru this is an interesting issue b/c the library is quite constrained in this area. I was looking at issuing a PR as you solicited in 2018 since it's still not addressed. However, I think it's worth a bit of discussion on approach. Here is the criteria around this I can see:
Considerations:
This would be very powerful in allowing very responsive handling of fill such as with SVG's. Let me know your thoughts. |
My preference for this would be to have it managed as an input. E.g. On a side note, please ping me on my personal email: (my GitHub alias separated by |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
fxFlexFill.<breakpoint alias> should limit directive to proper width range.
What is the current behavior?
Adding breakpoint alias seems to disable directive.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-flex-layout-seed-h5ajhj?file=app%2Ftest.component.ts
What is the use-case or motivation for changing an existing behavior?
Existing behaviour seems to be broken.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Every I tested.
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: